chrome/browser/ui/translate/translate_bubble_model_impl.h - Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/translate/translate_bubble_model_impl.h

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix namespace in .h and other minor review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/translate/translate_bubble_model.h ('K') | « chrome/browser/ui/translate/translate_bubble_model.h ('k') | chrome/browser/ui/translate/translate_bubble_model_impl.cc » ('j') | chrome/browser/ui/translate/translate_bubble_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/translate/translate_bubble_model_impl.h

diff --git a/chrome/browser/ui/translate/translate_bubble_model_impl.h b/chrome/browser/ui/translate/translate_bubble_model_impl.h

index d5219c2b47dac7ad65417eb56ee14615ae0ad887..1583f1f0dd960fa0ee3f7ea894e1362aeeb4628c 100644

--- a/chrome/browser/ui/translate/translate_bubble_model_impl.h

+++ b/chrome/browser/ui/translate/translate_bubble_model_impl.h

@@ -31,6 +31,7 @@ class TranslateBubbleModelImpl : public TranslateBubbleModel {

// TranslateBubbleModel methods.

TranslateBubbleModel::ViewState GetViewState() const override;

+ bool GetAlwaysTranslateChecked() const override;

msw 2016/04/29 20:00:00 nit: reorder override to match reordering in base

ftang 2016/04/29 22:37:00 Done.

void SetViewState(TranslateBubbleModel::ViewState view_state) override;

void ShowError(translate::TranslateErrors::Type error_type) override;

void GoBackFromAdvanced() override;