Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5345)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix namespace in .h and other minor review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | chrome/browser/translate/chrome_translate_client.cc » ('j') | chrome/browser/translate/chrome_translate_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 41bfa9bdbb0cc94f60e6080dea279b77fcd3327d..c635d16e368beb1675dfdb8f176cc86cdcc33068 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -11608,6 +11608,9 @@ Some features may be unavailable. Please check that the profile exists and you
<message name="IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLATE" desc="Text to show for the translate bubble label when that page is in specified language and ask if should translate.">
Would you like to translate this page?
</message>
+ <message name="IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLATE2" desc="Text to show for the translate bubble label when that page is in specified language and ask if should translate.">
msw 2016/04/29 19:59:59 nit: How about IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLA
ftang 2016/04/29 22:37:00 Done.
+ Do you want Google to translate this page from <ph name="source_language">$1<ex>Spanish</ex></ph> to <ph name="target_language">$2<ex>English</ex></ph>?
msw 2016/04/29 19:59:59 Not sure why we changed from "Would you like" to "
msw 2016/04/29 19:59:59 Remove the extra space here: "to <ph"
ftang 2016/04/29 22:37:00 Done.
ftang 2016/04/29 22:37:00 It is designed by our UI designer spec out in page
+ </message>
<message name="IDS_TRANSLATE_BUBBLE_ADVANCED" desc="Text to show for the translate bubble link label to jump to the advanced panel.">
Options
</message>
@@ -11636,7 +11639,7 @@ Some features may be unavailable. Please check that the profile exists and you
Try again
</message>
<message name="IDS_TRANSLATE_BUBBLE_ALWAYS" desc="Text to show for the translate bubble checkbox to always translate from one language to another">
- Always translate
+ Always do this
</message>
<message name="IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE" desc="Text to show for the translate bubble label when the page could not be translated.">
This page could not be translated.
« no previous file with comments | « no previous file | chrome/browser/translate/chrome_translate_client.cc » ('j') | chrome/browser/translate/chrome_translate_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698