Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test breakage Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.cc
diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc
index ce32fe0cfdbbcd393e6b4de9c39e5ac61e8e10e4..0b3b8c3462de67cdee507d95b356cfadfbf8cee4 100644
--- a/chrome/browser/translate/chrome_translate_client.cc
+++ b/chrome/browser/translate/chrome_translate_client.cc
@@ -204,8 +204,10 @@ void ChromeTranslateClient::ShowTranslateUI(
if (step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
// TODO(droger): Move this logic out of UI code.
GetLanguageState().SetTranslateEnabled(true);
- if (!GetLanguageState().HasLanguageChanged())
- return;
+ if (!base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2)) {
groby-ooo-7-16 2016/04/27 19:08:24 I'd prefer it if we could resolve the TODO, instea
ftang 2016/04/27 21:43:15 Not quit sure what you ask me to do. I try not to
groby-ooo-7-16 2016/04/29 05:26:14 I'm not sure what to do with this, either - it's u
+ if (!GetLanguageState().HasLanguageChanged())
+ return;
+ }
if (!triggered_from_menu) {
if (web_contents()->GetBrowserContext()->IsOffTheRecord())

Powered by Google App Engine
This is Rietveld 408576698