Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor changes in comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/gtest_prod_util.h" 11 #include "base/gtest_prod_util.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/strings/utf_string_conversions.h"
13 #include "chrome/browser/translate/chrome_translate_client.h" 14 #include "chrome/browser/translate/chrome_translate_client.h"
14 #include "chrome/browser/ui/translate/language_combobox_model.h" 15 #include "chrome/browser/ui/translate/language_combobox_model.h"
15 #include "chrome/browser/ui/translate/translate_bubble_model.h" 16 #include "chrome/browser/ui/translate/translate_bubble_model.h"
16 #include "chrome/browser/ui/translate/translate_bubble_test_utils.h" 17 #include "chrome/browser/ui/translate/translate_bubble_test_utils.h"
18 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
17 #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view .h" 19 #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view .h"
18 #include "components/translate/core/common/translate_errors.h" 20 #include "components/translate/core/common/translate_errors.h"
19 #include "content/public/browser/web_contents_observer.h" 21 #include "content/public/browser/web_contents_observer.h"
22 #include "ui/base/models/simple_menu_model.h"
20 #include "ui/views/controls/button/button.h" 23 #include "ui/views/controls/button/button.h"
24 #include "ui/views/controls/button/menu_button_listener.h"
21 #include "ui/views/controls/combobox/combobox_listener.h" 25 #include "ui/views/controls/combobox/combobox_listener.h"
22 #include "ui/views/controls/link_listener.h" 26 #include "ui/views/controls/link_listener.h"
27 #include "ui/views/controls/menu/menu_runner.h"
28 #include "ui/views/controls/styled_label_listener.h"
23 29
24 class Browser; 30 class Browser;
25 class PrefService;
26 31
27 namespace views { 32 namespace views {
28 class Checkbox; 33 class Checkbox;
29 class GridLayout;
30 class LabelButton; 34 class LabelButton;
31 class Link;
32 class View; 35 class View;
33 } 36 }
34 37
35 namespace ui { 38 namespace ui {
36 class SimpleComboboxModel; 39 class SimpleComboboxModel;
37 } 40 }
38 41
39 class TranslateBubbleView : public LocationBarBubbleDelegateView, 42 class TranslateBubbleView : public LocationBarBubbleDelegateView,
40 public views::ButtonListener, 43 public views::ButtonListener,
41 public views::ComboboxListener, 44 public views::ComboboxListener,
42 public views::LinkListener, 45 public views::LinkListener,
46 public views::MenuButtonListener,
47 public ui::SimpleMenuModel::Delegate,
48 public views::StyledLabelListener,
43 public content::WebContentsObserver { 49 public content::WebContentsObserver {
44 public: 50 public:
45 // Commands shown in the action-style combobox. The value corresponds to the 51 // Commands shown in the action-style combobox. The value corresponds to the
46 // position in the combobox menu. Gaps will become separators. 52 // position in the combobox menu. Gaps will become separators.
47 enum class DenialComboboxIndex { 53 enum class DenialComboboxIndex {
48 DONT_TRANSLATE = 0, 54 DONT_TRANSLATE = 0,
49 NEVER_TRANSLATE_LANGUAGE = 1, 55 NEVER_TRANSLATE_LANGUAGE = 1,
50 NEVER_TRANSLATE_SITE = 3, 56 NEVER_TRANSLATE_SITE = 3,
51 MENU_SIZE = 4, 57 MENU_SIZE = 4,
52 }; 58 };
53 59
60 // Item IDs for the denial button's menu.
61 enum DenialMenuItem { NEVER_TRANSLATE_LANGUAGE, NEVER_TRANSLATE_SITE };
62
54 ~TranslateBubbleView() override; 63 ~TranslateBubbleView() override;
55 64
56 // Shows the Translate bubble. Returns the newly created bubble's Widget or 65 // Shows the Translate bubble. Returns the newly created bubble's Widget or
57 // nullptr in cases when the bubble already exists or when the bubble is not 66 // nullptr in cases when the bubble already exists or when the bubble is not
58 // created. 67 // created.
59 // 68 //
60 // |is_user_gesture| is true when the bubble is shown on the user's deliberate 69 // |is_user_gesture| is true when the bubble is shown on the user's deliberate
61 // action. 70 // action.
62 static views::Widget* ShowBubble(views::View* anchor_view, 71 static views::Widget* ShowBubble(views::View* anchor_view,
63 content::WebContents* web_contents, 72 content::WebContents* web_contents,
64 translate::TranslateStep step, 73 translate::TranslateStep step,
65 translate::TranslateErrors::Type error_type, 74 translate::TranslateErrors::Type error_type,
66 DisplayReason reason); 75 DisplayReason reason);
67 76
68 // Closes the current bubble if it exists. 77 // Closes the current bubble if it exists.
69 static void CloseCurrentBubble(); 78 static void CloseCurrentBubble();
70 79
71 // Returns the bubble view currently shown. This may return NULL. 80 // Returns the bubble view currently shown. This may return NULL.
72 static TranslateBubbleView* GetCurrentBubble(); 81 static TranslateBubbleView* GetCurrentBubble();
73 82
74 TranslateBubbleModel* model() { return model_.get(); } 83 TranslateBubbleModel* model() { return model_.get(); }
75 84
76 // views::BubbleDialogDelegateView methods. 85 // views::BubbleDialogDelegateView methods.
77 void Init() override; 86 void Init() override;
78 void ButtonPressed(views::Button* sender, const ui::Event& event) override; 87 void ButtonPressed(views::Button* sender, const ui::Event& event) override;
79 88
80 // views::WidgetDelegate method. 89 // views::WidgetDelegate methods.
90 bool ShouldShowCloseButton() const override;
81 void WindowClosing() override; 91 void WindowClosing() override;
82 92
83 // views::View methods. 93 // views::View methods.
84 bool AcceleratorPressed(const ui::Accelerator& accelerator) override; 94 bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
85 gfx::Size GetPreferredSize() const override; 95 gfx::Size GetPreferredSize() const override;
86 96
87 // views::CombboxListener methods. 97 // views::CombboxListener methods.
88 void OnPerformAction(views::Combobox* combobox) override; 98 void OnPerformAction(views::Combobox* combobox) override;
89 99
90 // views::LinkListener method. 100 // views::LinkListener method.
91 void LinkClicked(views::Link* source, int event_flags) override; 101 void LinkClicked(views::Link* source, int event_flags) override;
92 102
103 // views::MenuButtonListener method.
104 void OnMenuButtonClicked(views::MenuButton* source,
105 const gfx::Point& point,
106 const ui::Event* event) override;
107
108 // ui::SimpleMenuModel::Delegate methods.
109 bool IsCommandIdChecked(int command_id) const override;
110 bool IsCommandIdEnabled(int command_id) const override;
111 bool GetAcceleratorForCommandId(int command_id,
112 ui::Accelerator* accelerator) override;
113 void ExecuteCommand(int command_id, int event_flags) override;
114
115 // views::StyledLabelListener method.
116 void StyledLabelLinkClicked(views::StyledLabel* label,
117 const gfx::Range& range,
118 int event_flags) override;
119
93 // content::WebContentsObserver method. 120 // content::WebContentsObserver method.
94 void WebContentsDestroyed() override; 121 void WebContentsDestroyed() override;
95 122
123 // Overridden from views::WidgetObserver:
124 void OnWidgetClosing(views::Widget* widget) override;
125
96 // Returns the current view state. 126 // Returns the current view state.
97 TranslateBubbleModel::ViewState GetViewState() const; 127 TranslateBubbleModel::ViewState GetViewState() const;
98 128
99 private: 129 private:
100 enum LinkID { 130 enum LinkID {
101 LINK_ID_ADVANCED, 131 LINK_ID_ADVANCED,
102 LINK_ID_LANGUAGE_SETTINGS, 132 LINK_ID_LANGUAGE_SETTINGS,
103 }; 133 };
104 134
105 enum ButtonID { 135 enum ButtonID {
106 BUTTON_ID_TRANSLATE, 136 BUTTON_ID_TRANSLATE,
107 BUTTON_ID_DONE, 137 BUTTON_ID_DONE,
108 BUTTON_ID_CANCEL, 138 BUTTON_ID_CANCEL,
109 BUTTON_ID_SHOW_ORIGINAL, 139 BUTTON_ID_SHOW_ORIGINAL,
110 BUTTON_ID_TRY_AGAIN, 140 BUTTON_ID_TRY_AGAIN,
111 BUTTON_ID_ALWAYS_TRANSLATE, 141 BUTTON_ID_ALWAYS_TRANSLATE,
112 }; 142 };
113 143
114 enum ComboboxID { 144 enum ComboboxID {
115 COMBOBOX_ID_DENIAL, 145 COMBOBOX_ID_DENIAL,
116 COMBOBOX_ID_SOURCE_LANGUAGE, 146 COMBOBOX_ID_SOURCE_LANGUAGE,
117 COMBOBOX_ID_TARGET_LANGUAGE, 147 COMBOBOX_ID_TARGET_LANGUAGE,
118 }; 148 };
119 149
120 friend class TranslateBubbleViewTest; 150 friend class TranslateBubbleViewTest;
121 friend void ::translate::test_utils::PressTranslate(::Browser*); 151 friend void ::translate::test_utils::PressTranslate(::Browser*);
122 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TranslateButton); 152 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TranslateButton);
153 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TranslateButtonIn2016Q2UI);
154 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, CloseButtonIn2016Q2UI);
123 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, AdvancedLink); 155 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, AdvancedLink);
156 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, AdvancedLinkIn2016Q2UI);
124 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, ShowOriginalButton); 157 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, ShowOriginalButton);
125 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TryAgainButton); 158 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TryAgainButton);
126 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 159 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
127 AlwaysTranslateCheckboxAndCancelButton); 160 AlwaysTranslateCheckboxAndCancelButton);
128 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 161 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
129 AlwaysTranslateCheckboxAndDoneButton); 162 AlwaysTranslateCheckboxAndDoneButton);
130 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, DoneButton); 163 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, DoneButton);
131 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 164 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
132 DoneButtonWithoutTranslating); 165 DoneButtonWithoutTranslating);
133 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 166 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 209
177 // Switches the view type. 210 // Switches the view type.
178 void SwitchView(TranslateBubbleModel::ViewState view_state); 211 void SwitchView(TranslateBubbleModel::ViewState view_state);
179 212
180 // Switches to the error view. 213 // Switches to the error view.
181 void SwitchToErrorView(translate::TranslateErrors::Type error_type); 214 void SwitchToErrorView(translate::TranslateErrors::Type error_type);
182 215
183 // Updates the advanced view. 216 // Updates the advanced view.
184 void UpdateAdvancedView(); 217 void UpdateAdvancedView();
185 218
219 // Logs metrics for the user's TranslateBubbleUiEvent |action|.
220 void ReportUiAction(translate::TranslateBubbleUiEvent action);
221
186 static TranslateBubbleView* translate_bubble_view_; 222 static TranslateBubbleView* translate_bubble_view_;
187 223
188 views::View* before_translate_view_; 224 views::View* before_translate_view_;
189 views::View* translating_view_; 225 views::View* translating_view_;
190 views::View* after_translate_view_; 226 views::View* after_translate_view_;
191 views::View* error_view_; 227 views::View* error_view_;
192 views::View* advanced_view_; 228 views::View* advanced_view_;
193 229
194 std::unique_ptr<ui::SimpleComboboxModel> denial_combobox_model_; 230 std::unique_ptr<ui::SimpleComboboxModel> denial_combobox_model_;
195 std::unique_ptr<LanguageComboboxModel> source_language_combobox_model_; 231 std::unique_ptr<LanguageComboboxModel> source_language_combobox_model_;
196 std::unique_ptr<LanguageComboboxModel> target_language_combobox_model_; 232 std::unique_ptr<LanguageComboboxModel> target_language_combobox_model_;
197 233
198 views::Combobox* denial_combobox_; 234 views::Combobox* denial_combobox_;
199 views::Combobox* source_language_combobox_; 235 views::Combobox* source_language_combobox_;
200 views::Combobox* target_language_combobox_; 236 views::Combobox* target_language_combobox_;
201 237
202 views::Checkbox* always_translate_checkbox_; 238 views::Checkbox* always_translate_checkbox_;
203 239
204 views::LabelButton* advanced_cancel_button_; 240 views::LabelButton* advanced_cancel_button_;
205 views::LabelButton* advanced_done_button_; 241 views::LabelButton* advanced_done_button_;
206 242
243 views::MenuButton* denial_menu_button_;
244 std::unique_ptr<ui::SimpleMenuModel> denial_menu_model_;
245 std::unique_ptr<views::MenuRunner> denial_menu_runner_;
246
207 std::unique_ptr<TranslateBubbleModel> model_; 247 std::unique_ptr<TranslateBubbleModel> model_;
208 248
209 translate::TranslateErrors::Type error_type_; 249 translate::TranslateErrors::Type error_type_;
210 250
211 // Whether the window is an incognito window. 251 // Whether the window is an incognito window.
212 const bool is_in_incognito_window_; 252 const bool is_in_incognito_window_;
213 253
214 // Whether the translation is acutually executed.
215 bool translate_executed_;
216
217 DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView); 254 DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView);
218 }; 255 };
219 256
220 #endif // CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_ 257 #endif // CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698