Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.cc

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change based on msw comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h" 5 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 9
10 namespace {
11
12 enum TranslateBubbleUiEvent {
13 // Bubble enters the options state.
14 SET_STATE_OPTIONS = 1,
15
16 // Bubble leaves the options state.
17 LEAVE_STATE_OPTIONS = 2,
18
19 TRANSLATE_BUBBLE_UI_EVENT_MAX
20 };
21
22 } // namespace
23
24 TranslateBubbleViewStateTransition::TranslateBubbleViewStateTransition( 10 TranslateBubbleViewStateTransition::TranslateBubbleViewStateTransition(
25 TranslateBubbleModel::ViewState view_state) 11 TranslateBubbleModel::ViewState view_state)
26 : view_state_(view_state), 12 : view_state_(view_state), view_state_before_advanced_view_(view_state) {
27 view_state_before_advanced_view_(view_state) {
28 // The initial view type must not be 'Advanced'. 13 // The initial view type must not be 'Advanced'.
29 DCHECK_NE(TranslateBubbleModel::VIEW_STATE_ADVANCED, view_state_); 14 DCHECK_NE(TranslateBubbleModel::VIEW_STATE_ADVANCED, view_state_);
30 } 15 }
31 16
32 void TranslateBubbleViewStateTransition::SetViewState( 17 void TranslateBubbleViewStateTransition::SetViewState(
33 TranslateBubbleModel::ViewState view_state) { 18 TranslateBubbleModel::ViewState view_state) {
34 view_state_ = view_state; 19 view_state_ = view_state;
35 if (view_state != TranslateBubbleModel::VIEW_STATE_ADVANCED) 20 if (view_state != TranslateBubbleModel::VIEW_STATE_ADVANCED)
36 view_state_before_advanced_view_ = view_state; 21 view_state_before_advanced_view_ = view_state;
37 else 22 else
38 UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent", SET_STATE_OPTIONS, 23 UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent",
39 TRANSLATE_BUBBLE_UI_EVENT_MAX); 24 translate::SET_STATE_OPTIONS,
25 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
40 } 26 }
41 27
42 void TranslateBubbleViewStateTransition::GoBackFromAdvanced() { 28 void TranslateBubbleViewStateTransition::GoBackFromAdvanced() {
43 DCHECK(view_state_ == TranslateBubbleModel::VIEW_STATE_ADVANCED); 29 DCHECK(view_state_ == TranslateBubbleModel::VIEW_STATE_ADVANCED);
44 UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent", LEAVE_STATE_OPTIONS, 30 UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent",
45 TRANSLATE_BUBBLE_UI_EVENT_MAX); 31 translate::LEAVE_STATE_OPTIONS,
32 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
46 SetViewState(view_state_before_advanced_view_); 33 SetViewState(view_state_before_advanced_view_);
47 } 34 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698