Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change to use MenuButton with MenuRunner for 'Options' menu in new UI based on msw review request. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/gtest_prod_util.h" 11 #include "base/gtest_prod_util.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/strings/utf_string_conversions.h"
13 #include "chrome/browser/translate/chrome_translate_client.h" 14 #include "chrome/browser/translate/chrome_translate_client.h"
14 #include "chrome/browser/ui/translate/language_combobox_model.h" 15 #include "chrome/browser/ui/translate/language_combobox_model.h"
15 #include "chrome/browser/ui/translate/translate_bubble_model.h" 16 #include "chrome/browser/ui/translate/translate_bubble_model.h"
16 #include "chrome/browser/ui/translate/translate_bubble_test_utils.h" 17 #include "chrome/browser/ui/translate/translate_bubble_test_utils.h"
17 #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view .h" 18 #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view .h"
18 #include "components/translate/core/common/translate_errors.h" 19 #include "components/translate/core/common/translate_errors.h"
19 #include "content/public/browser/web_contents_observer.h" 20 #include "content/public/browser/web_contents_observer.h"
21 #include "ui/base/models/simple_menu_model.h"
20 #include "ui/views/controls/button/button.h" 22 #include "ui/views/controls/button/button.h"
23 #include "ui/views/controls/button/menu_button_listener.h"
21 #include "ui/views/controls/combobox/combobox_listener.h" 24 #include "ui/views/controls/combobox/combobox_listener.h"
22 #include "ui/views/controls/link_listener.h" 25 #include "ui/views/controls/link_listener.h"
26 #include "ui/views/controls/menu/menu_runner.h"
27 #include "ui/views/controls/styled_label_listener.h"
23 28
24 class Browser; 29 class Browser;
25 class PrefService; 30 class PrefService;
26 31
32 namespace gfx {
33 class Range;
34 }
35
27 namespace views { 36 namespace views {
28 class Checkbox; 37 class Checkbox;
29 class GridLayout; 38 class GridLayout;
30 class LabelButton; 39 class LabelButton;
31 class Link; 40 class Link;
32 class View; 41 class View;
42 class StyledLabel;
33 } 43 }
34 44
35 namespace ui { 45 namespace ui {
36 class SimpleComboboxModel; 46 class SimpleComboboxModel;
37 } 47 }
38 48
39 class TranslateBubbleView : public LocationBarBubbleDelegateView, 49 class TranslateBubbleView : public LocationBarBubbleDelegateView,
40 public views::ButtonListener, 50 public views::ButtonListener,
41 public views::ComboboxListener, 51 public views::ComboboxListener,
42 public views::LinkListener, 52 public views::LinkListener,
53 public views::MenuButtonListener,
54 public ui::SimpleMenuModel::Delegate,
55 public views::StyledLabelListener,
43 public content::WebContentsObserver { 56 public content::WebContentsObserver {
44 public: 57 public:
45 // Commands shown in the action-style combobox. The value corresponds to the 58 // Commands shown in the action-style combobox. The value corresponds to the
46 // position in the combobox menu. Gaps will become separators. 59 // position in the combobox menu. Gaps will become separators.
47 enum class DenialComboboxIndex { 60 enum class DenialComboboxIndex {
48 DONT_TRANSLATE = 0, 61 DONT_TRANSLATE = 0,
49 NEVER_TRANSLATE_LANGUAGE = 1, 62 NEVER_TRANSLATE_LANGUAGE = 1,
50 NEVER_TRANSLATE_SITE = 3, 63 NEVER_TRANSLATE_SITE = 3,
51 MENU_SIZE = 4, 64 MENU_SIZE = 4,
52 }; 65 };
53 66
67 enum DenialMenuItem {
68 NEVER_TRANSLATE_LANGUAGE = 0,
msw 2016/05/03 18:16:41 nit: explicit enum values (= 0, = 1) are not neede
ftang 2016/05/03 20:34:50 Done.
69 NEVER_TRANSLATE_SITE = 1,
70 };
71
54 ~TranslateBubbleView() override; 72 ~TranslateBubbleView() override;
55 73
56 // Shows the Translate bubble. Returns the newly created bubble's Widget or 74 // Shows the Translate bubble. Returns the newly created bubble's Widget or
57 // nullptr in cases when the bubble already exists or when the bubble is not 75 // nullptr in cases when the bubble already exists or when the bubble is not
58 // created. 76 // created.
59 // 77 //
60 // |is_user_gesture| is true when the bubble is shown on the user's deliberate 78 // |is_user_gesture| is true when the bubble is shown on the user's deliberate
61 // action. 79 // action.
62 static views::Widget* ShowBubble(views::View* anchor_view, 80 static views::Widget* ShowBubble(views::View* anchor_view,
63 content::WebContents* web_contents, 81 content::WebContents* web_contents,
64 translate::TranslateStep step, 82 translate::TranslateStep step,
65 translate::TranslateErrors::Type error_type, 83 translate::TranslateErrors::Type error_type,
66 DisplayReason reason); 84 DisplayReason reason);
67 85
68 // Closes the current bubble if it exists. 86 // Closes the current bubble if it exists.
69 static void CloseCurrentBubble(); 87 static void CloseCurrentBubble();
70 88
71 // Returns the bubble view currently shown. This may return NULL. 89 // Returns the bubble view currently shown. This may return NULL.
72 static TranslateBubbleView* GetCurrentBubble(); 90 static TranslateBubbleView* GetCurrentBubble();
73 91
74 TranslateBubbleModel* model() { return model_.get(); } 92 TranslateBubbleModel* model() { return model_.get(); }
75 93
76 // views::BubbleDialogDelegateView methods. 94 // views::BubbleDialogDelegateView methods.
77 void Init() override; 95 void Init() override;
78 void ButtonPressed(views::Button* sender, const ui::Event& event) override; 96 void ButtonPressed(views::Button* sender, const ui::Event& event) override;
79 97
80 // views::WidgetDelegate method. 98 // views::WidgetDelegate methods.
99 bool ShouldShowCloseButton() const override;
81 void WindowClosing() override; 100 void WindowClosing() override;
82 101
83 // views::View methods. 102 // views::View methods.
84 bool AcceleratorPressed(const ui::Accelerator& accelerator) override; 103 bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
85 gfx::Size GetPreferredSize() const override; 104 gfx::Size GetPreferredSize() const override;
86 105
87 // views::CombboxListener methods. 106 // views::CombboxListener methods.
88 void OnPerformAction(views::Combobox* combobox) override; 107 void OnPerformAction(views::Combobox* combobox) override;
89 108
90 // views::LinkListener method. 109 // views::LinkListener method.
91 void LinkClicked(views::Link* source, int event_flags) override; 110 void LinkClicked(views::Link* source, int event_flags) override;
92 111
112 // views::MenuButtonListener method.
113 void OnMenuButtonClicked(views::MenuButton* source,
114 const gfx::Point& point,
115 const ui::Event* event) override;
116
117 // ui::SimpleMenuModel::Delegate methods.
118 bool IsCommandIdChecked(int command_id) const override;
119 bool IsCommandIdEnabled(int command_id) const override;
120 bool GetAcceleratorForCommandId(int command_id,
121 ui::Accelerator* accelerator) override;
122 void ExecuteCommand(int command_id, int event_flags) override;
123
124 // views::StyledLabelListener method.
125 void StyledLabelLinkClicked(views::StyledLabel* label,
126 const gfx::Range& range,
127 int event_flags) override;
128
93 // content::WebContentsObserver method. 129 // content::WebContentsObserver method.
94 void WebContentsDestroyed() override; 130 void WebContentsDestroyed() override;
95 131
132 // Overridden from views::WidgetObserver:
133 void OnWidgetClosing(views::Widget* widget) override;
134
96 // Returns the current view state. 135 // Returns the current view state.
97 TranslateBubbleModel::ViewState GetViewState() const; 136 TranslateBubbleModel::ViewState GetViewState() const;
98 137
99 private: 138 private:
100 enum LinkID { 139 enum LinkID {
101 LINK_ID_ADVANCED, 140 LINK_ID_ADVANCED,
102 LINK_ID_LANGUAGE_SETTINGS, 141 LINK_ID_LANGUAGE_SETTINGS,
103 }; 142 };
104 143
105 enum ButtonID { 144 enum ButtonID {
106 BUTTON_ID_TRANSLATE, 145 BUTTON_ID_TRANSLATE,
107 BUTTON_ID_DONE, 146 BUTTON_ID_DONE,
108 BUTTON_ID_CANCEL, 147 BUTTON_ID_CANCEL,
109 BUTTON_ID_SHOW_ORIGINAL, 148 BUTTON_ID_SHOW_ORIGINAL,
110 BUTTON_ID_TRY_AGAIN, 149 BUTTON_ID_TRY_AGAIN,
111 BUTTON_ID_ALWAYS_TRANSLATE, 150 BUTTON_ID_ALWAYS_TRANSLATE,
112 }; 151 };
113 152
114 enum ComboboxID { 153 enum ComboboxID {
115 COMBOBOX_ID_DENIAL, 154 COMBOBOX_ID_DENIAL,
116 COMBOBOX_ID_SOURCE_LANGUAGE, 155 COMBOBOX_ID_SOURCE_LANGUAGE,
117 COMBOBOX_ID_TARGET_LANGUAGE, 156 COMBOBOX_ID_TARGET_LANGUAGE,
118 }; 157 };
119 158
120 friend class TranslateBubbleViewTest; 159 friend class TranslateBubbleViewTest;
121 friend void ::translate::test_utils::PressTranslate(::Browser*); 160 friend void ::translate::test_utils::PressTranslate(::Browser*);
122 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TranslateButton); 161 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TranslateButton);
162 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TranslateButtonIn2016Q2UI);
163 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, CloseButtonIn2016Q2UI);
123 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, AdvancedLink); 164 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, AdvancedLink);
165 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, AdvancedLinkIn2016Q2UI);
124 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, ShowOriginalButton); 166 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, ShowOriginalButton);
125 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TryAgainButton); 167 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, TryAgainButton);
126 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 168 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
127 AlwaysTranslateCheckboxAndCancelButton); 169 AlwaysTranslateCheckboxAndCancelButton);
128 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 170 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
129 AlwaysTranslateCheckboxAndDoneButton); 171 AlwaysTranslateCheckboxAndDoneButton);
130 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, DoneButton); 172 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, DoneButton);
131 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 173 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
132 DoneButtonWithoutTranslating); 174 DoneButtonWithoutTranslating);
133 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, 175 FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 218
177 // Switches the view type. 219 // Switches the view type.
178 void SwitchView(TranslateBubbleModel::ViewState view_state); 220 void SwitchView(TranslateBubbleModel::ViewState view_state);
179 221
180 // Switches to the error view. 222 // Switches to the error view.
181 void SwitchToErrorView(translate::TranslateErrors::Type error_type); 223 void SwitchToErrorView(translate::TranslateErrors::Type error_type);
182 224
183 // Updates the advanced view. 225 // Updates the advanced view.
184 void UpdateAdvancedView(); 226 void UpdateAdvancedView();
185 227
228 void ReportUiAction(int action);
229
186 static TranslateBubbleView* translate_bubble_view_; 230 static TranslateBubbleView* translate_bubble_view_;
187 231
188 views::View* before_translate_view_; 232 views::View* before_translate_view_;
189 views::View* translating_view_; 233 views::View* translating_view_;
190 views::View* after_translate_view_; 234 views::View* after_translate_view_;
191 views::View* error_view_; 235 views::View* error_view_;
192 views::View* advanced_view_; 236 views::View* advanced_view_;
193 237
194 std::unique_ptr<ui::SimpleComboboxModel> denial_combobox_model_; 238 std::unique_ptr<ui::SimpleComboboxModel> denial_combobox_model_;
195 std::unique_ptr<LanguageComboboxModel> source_language_combobox_model_; 239 std::unique_ptr<LanguageComboboxModel> source_language_combobox_model_;
196 std::unique_ptr<LanguageComboboxModel> target_language_combobox_model_; 240 std::unique_ptr<LanguageComboboxModel> target_language_combobox_model_;
197 241
198 views::Combobox* denial_combobox_; 242 views::Combobox* denial_combobox_;
199 views::Combobox* source_language_combobox_; 243 views::Combobox* source_language_combobox_;
200 views::Combobox* target_language_combobox_; 244 views::Combobox* target_language_combobox_;
201 245
202 views::Checkbox* always_translate_checkbox_; 246 views::Checkbox* always_translate_checkbox_;
203 247
204 views::LabelButton* advanced_cancel_button_; 248 views::LabelButton* advanced_cancel_button_;
205 views::LabelButton* advanced_done_button_; 249 views::LabelButton* advanced_done_button_;
206 250
251 std::unique_ptr<ui::SimpleMenuModel> denial_menu_model_;
252
253 std::unique_ptr<views::MenuRunner> denial_menu_runner_;
254
207 std::unique_ptr<TranslateBubbleModel> model_; 255 std::unique_ptr<TranslateBubbleModel> model_;
208 256
209 translate::TranslateErrors::Type error_type_; 257 translate::TranslateErrors::Type error_type_;
210 258
211 // Whether the window is an incognito window. 259 // Whether the window is an incognito window.
212 const bool is_in_incognito_window_; 260 const bool is_in_incognito_window_;
213 261
214 // Whether the translation is acutually executed. 262 // Use the new (2016 Q2) translate UI.
215 bool translate_executed_; 263 bool use_2016_q2_ui_;
216 264
217 DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView); 265 DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView);
218 }; 266 };
219 267
220 #endif // CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_ 268 #endif // CHROME_BROWSER_UI_VIEWS_TRANSLATE_TRANSLATE_BUBBLE_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698