chrome/app/generated_resources.grd - Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix namespace in .h and other minor review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 41bfa9bdbb0cc94f60e6080dea279b77fcd3327d..c635d16e368beb1675dfdb8f176cc86cdcc33068 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -11608,6 +11608,9 @@ Some features may be unavailable. Please check that the profile exists and you

Would you like to translate this page?

</message>

+ <message name="IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLATE2" desc="Text to show for the translate bubble label when that page is in specified language and ask if should translate.">

msw 2016/04/29 19:59:59 nit: How about IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLA

ftang 2016/04/29 22:37:00 Done.

+ Do you want Google to translate this page from <ph name="source_language">$1<ex>Spanish</ex></ph> to <ph name="target_language">$2<ex>English</ex></ph>?

msw 2016/04/29 19:59:59 Not sure why we changed from "Would you like" to "

msw 2016/04/29 19:59:59 Remove the extra space here: "to <ph"

ftang 2016/04/29 22:37:00 Done.

ftang 2016/04/29 22:37:00 It is designed by our UI designer spec out in page

+ </message>

Options

</message>

@@ -11636,7 +11639,7 @@ Some features may be unavailable. Please check that the profile exists and you

Try again

</message>

- Always translate

+ Always do this

</message>

This page could not be translated.

« no previous file with comments | « no previous file | chrome/browser/translate/chrome_translate_client.cc » ('j') | chrome/browser/translate/chrome_translate_client.cc » ('J')