Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc

Issue 1923143003: Implement the 2016Q2 Translate UI designe spec out in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test breakage Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "chrome/browser/ui/translate/translate_bubble_model.h" 10 #include "chrome/browser/ui/translate/translate_bubble_model.h"
(...skipping 10 matching lines...) Expand all
21 class MockTranslateBubbleModel : public TranslateBubbleModel { 21 class MockTranslateBubbleModel : public TranslateBubbleModel {
22 public: 22 public:
23 explicit MockTranslateBubbleModel(TranslateBubbleModel::ViewState view_state) 23 explicit MockTranslateBubbleModel(TranslateBubbleModel::ViewState view_state)
24 : view_state_transition_(view_state), 24 : view_state_transition_(view_state),
25 error_type_(translate::TranslateErrors::NONE), 25 error_type_(translate::TranslateErrors::NONE),
26 original_language_index_(0), 26 original_language_index_(0),
27 target_language_index_(1), 27 target_language_index_(1),
28 never_translate_language_(false), 28 never_translate_language_(false),
29 never_translate_site_(false), 29 never_translate_site_(false),
30 should_always_translate_(false), 30 should_always_translate_(false),
31 always_translate_checked_(false),
groby-ooo-7-16 2016/04/27 19:08:25 Any tests for the new features?
ftang 2016/04/27 21:43:15 Done.
31 set_always_translate_called_count_(0), 32 set_always_translate_called_count_(0),
32 translate_called_(false), 33 translate_called_(false),
33 revert_translation_called_(false), 34 revert_translation_called_(false),
34 translation_declined_(false), 35 translation_declined_(false),
35 original_language_index_on_translation_(-1), 36 original_language_index_on_translation_(-1),
36 target_language_index_on_translation_(-1) {} 37 target_language_index_on_translation_(-1) {}
37 38
38 TranslateBubbleModel::ViewState GetViewState() const override { 39 TranslateBubbleModel::ViewState GetViewState() const override {
39 return view_state_transition_.view_state(); 40 return view_state_transition_.view_state();
40 } 41 }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 void DeclineTranslation() override { translation_declined_ = true; } 75 void DeclineTranslation() override { translation_declined_ = true; }
75 76
76 void SetNeverTranslateLanguage(bool value) override { 77 void SetNeverTranslateLanguage(bool value) override {
77 never_translate_language_ = value; 78 never_translate_language_ = value;
78 } 79 }
79 80
80 void SetNeverTranslateSite(bool value) override { 81 void SetNeverTranslateSite(bool value) override {
81 never_translate_site_ = value; 82 never_translate_site_ = value;
82 } 83 }
83 84
85 bool GetAlwaysTranslateChecked() const override {
86 return always_translate_checked_;
87 }
84 bool ShouldAlwaysTranslate() const override { 88 bool ShouldAlwaysTranslate() const override {
85 return should_always_translate_; 89 return should_always_translate_;
86 } 90 }
87 91
88 void SetAlwaysTranslate(bool value) override { 92 void SetAlwaysTranslate(bool value) override {
89 should_always_translate_ = value; 93 should_always_translate_ = value;
90 set_always_translate_called_count_++; 94 set_always_translate_called_count_++;
91 } 95 }
92 96
93 void Translate() override { 97 void Translate() override {
(...skipping 12 matching lines...) Expand all
106 target_language_index_on_translation_ == target_language_index_; 110 target_language_index_on_translation_ == target_language_index_;
107 } 111 }
108 112
109 TranslateBubbleViewStateTransition view_state_transition_; 113 TranslateBubbleViewStateTransition view_state_transition_;
110 translate::TranslateErrors::Type error_type_; 114 translate::TranslateErrors::Type error_type_;
111 int original_language_index_; 115 int original_language_index_;
112 int target_language_index_; 116 int target_language_index_;
113 bool never_translate_language_; 117 bool never_translate_language_;
114 bool never_translate_site_; 118 bool never_translate_site_;
115 bool should_always_translate_; 119 bool should_always_translate_;
120 bool always_translate_checked_;
116 int set_always_translate_called_count_; 121 int set_always_translate_called_count_;
117 bool translate_called_; 122 bool translate_called_;
118 bool revert_translation_called_; 123 bool revert_translation_called_;
119 bool translation_declined_; 124 bool translation_declined_;
120 int original_language_index_on_translation_; 125 int original_language_index_on_translation_;
121 int target_language_index_on_translation_; 126 int target_language_index_on_translation_;
122 }; 127 };
123 128
124 } // namespace 129 } // namespace
125 130
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 359
355 TEST_F(TranslateBubbleViewTest, CancelButtonReturningError) { 360 TEST_F(TranslateBubbleViewTest, CancelButtonReturningError) {
356 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ERROR); 361 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ERROR);
357 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED); 362 bubble_->SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
358 363
359 // Click the "Cancel" button to go back. 364 // Click the "Cancel" button to go back.
360 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState()); 365 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ADVANCED, bubble_->GetViewState());
361 bubble_->HandleButtonPressed(TranslateBubbleView::BUTTON_ID_CANCEL); 366 bubble_->HandleButtonPressed(TranslateBubbleView::BUTTON_ID_CANCEL);
362 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ERROR, bubble_->GetViewState()); 367 EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ERROR, bubble_->GetViewState());
363 } 368 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698