Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1923143002: Remove as checks bloating sample dart apps by 4K (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove as checks bloating sample dart apps by 4K BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/6ef4eae35feaeceafcacff7458bc862e45edb6eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/dom/src/shared_html.dart View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 8 months ago (2016-04-27 00:25:22 UTC) #2
sra1
lgtm
4 years, 8 months ago (2016-04-27 00:26:57 UTC) #3
Jacob
4 years, 7 months ago (2016-04-27 15:53:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ef4eae35feaeceafcacff7458bc862e45edb6eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698