|
Make ChromeSigninClient a BrowserContextKeyedService
This CL moves ChromeSigninClient from being created in SigninManagerFactory and
owned by SigninManager into being a BCKS. The motivation is that other core
Signin classes (e.g., *ProfileOAuth2TokenService) will need access to the
SigninClient instance as well. ChromeSigninClient being a BCKS enables such
access, as the respective factories can simply get the ChromeSigninClient
instance from the ChromeSigninClientFactory in order to pass it in to the core
classes that are being created.
BUG= 350710
R=rogerta@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255951
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+90 lines, -15 lines) |
Patch |
 |
M |
chrome/browser/signin/chrome_signin_client.h
|
View
|
1
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/signin/chrome_signin_client_factory.h
|
View
|
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/signin/chrome_signin_client_factory.cc
|
View
|
1
2
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/fake_signin_manager.cc
|
View
|
1
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_manager.h
|
View
|
1
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_manager.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_manager_factory.cc
|
View
|
1
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/signin/signin_manager_unittest.cc
|
View
|
1
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|