Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1923103002: [css-flexbox] Factor alignment calculations out of alignChildren() (Closed)

Created:
4 years, 7 months ago by cbiesinger
Modified:
4 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Factor alignment calculations out of alignChildren() This way, they can be reused for computing the position of abspos children. See also https://codereview.chromium.org/1920453003/ R=eae@chromium.org,leviw@chromium.org Committed: https://crrev.com/0d47d0d98550e87a4578c14394469166669c5cba Cr-Commit-Position: refs/heads/master@{#389948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -41 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +47 lines, -41 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cbiesinger
4 years, 7 months ago (2016-04-26 20:58:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923103002/1
4 years, 7 months ago (2016-04-26 20:59:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 22:32:39 UTC) #5
eae
LGTM, very nice!
4 years, 7 months ago (2016-04-27 00:02:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923103002/1
4 years, 7 months ago (2016-04-27 00:02:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 00:07:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 00:09:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d47d0d98550e87a4578c14394469166669c5cba
Cr-Commit-Position: refs/heads/master@{#389948}

Powered by Google App Engine
This is Rietveld 408576698