Remove IFX_SystemHandler.

Remove IFX_SystemHandler.

This CL folds IFX_SystemHandler into CFX_SystemHandler. Methods which either
had no implementation, or returned a default value have been removed.

Committed: https://pdfium.googlesource.com/pdfium/+/b95901091d63ce09accec3088945955f969d46e1

[dsinclair, 2016-04-26 20:58:03]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-26 20:58:04]

PTAL.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_Edit.cpp
File fpdfsdk/pdfwindow/PWL_Edit.cpp (left):

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:139: swClipboard =
pSH->GetClipboardText(GetAttachedHWnd());
GetClipboardText always returned L"" so this will always return FALSE.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:151: pSH->SetClipboardText(GetAttachedHWnd(),
str);
SetClipboardText just did a return FALSE.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:155: if (!CanPaste())
CanPaste would always be FALSE.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:507: FX_HMENU hPopup = pSH->CreatePopupMenu();
CreatePopupMenu always returned nullptr.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.cpp (left):

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.cpp:287: sFontName =
m_pSystemHandler->GetNativeTrueTypeFont(nCharset);
GetNativeTrueTypeFont always returns ""

[Tom Sepez, 2016-04-26 21:37:17]

lgtm

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h
File fpdfsdk/cfx_systemhandler.h (right):

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:58: FX_BOOL IsSelectionImplemented();
nit: can this be bool and a const method?

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:69: FX_BOOL IsSHIFTKeyDown(uint32_t nFlag);
nit: same here.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:76: int32_t GetCharSet() { return m_nCharSet; }
nit: I know this is const :)

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:80: CPDFDoc_Environment* m_pEnv;
can this be CPDFDOC_Environment* const m_pEnv; ?

[dsinclair, 2016-04-27 13:26:09]

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h
File fpdfsdk/cfx_systemhandler.h (right):

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:58: FX_BOOL IsSelectionImplemented();
On 2016/04/26 21:37:17, Tom Sepez wrote:
> nit: can this be bool and a const method?

Done.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:69: FX_BOOL IsSHIFTKeyDown(uint32_t nFlag);
On 2016/04/26 21:37:16, Tom Sepez wrote:
> nit: same here.

Done.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:76: int32_t GetCharSet() { return m_nCharSet; }
On 2016/04/26 21:37:16, Tom Sepez wrote:
> nit: I know this is const :)

Done.

https://codereview.chromium.org/1923093002/diff/1/fpdfsdk/cfx_systemhandler.h...
fpdfsdk/cfx_systemhandler.h:80: CPDFDoc_Environment* m_pEnv;
On 2016/04/26 21:37:16, Tom Sepez wrote:
> can this be CPDFDOC_Environment* const m_pEnv; ?

Done.

[dsinclair, 2016-04-27 13:26:15]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-27 13:26:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1923093002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-27 13:26:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1923093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1923093002/20001

[commit-bot: I haz the power, 2016-04-27 13:39:03]

Description was changed from

==========
Remove IFX_SystemHandler.

This CL folds IFX_SystemHandler into CFX_SystemHandler. Methods which either
had no implementation, or returned a default value have been removed.
==========

to

==========
Remove IFX_SystemHandler.

This CL folds IFX_SystemHandler into CFX_SystemHandler. Methods which either
had no implementation, or returned a default value have been removed.

Committed:
https://pdfium.googlesource.com/pdfium/+/b95901091d63ce09accec3088945955f969d...
==========

[commit-bot: I haz the power, 2016-04-27 13:39:04]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b95901091d63ce09accec3088945955f969d...