Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1923053002: Revert of Raise exception when devices fail to list tests. (Closed)

Created:
4 years, 8 months ago by mikecase (-- gone --)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Raise exception when devices fail to list tests. (patchset #2 id:20001 of https://codereview.chromium.org/1915273002/ ) Reason for revert: Looks like it is breaking upstream android bots https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/34054/steps/android_webview_unittests/logs/stdio Original issue's description: > Raise exception when devices fail to list tests. > > Before we only make sure that list of test cases are not None, but then > we realise that list of test cases should not be empty too, since > sometimes when devices fail to list tests, they will not return None, > but will return an empty list. > > BUG=585585 > > Committed: https://crrev.com/3d73e44f7177fe1dbb6e868120b985a6c9fb8a30 > Cr-Commit-Position: refs/heads/master@{#389576} TBR=jbudorick@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
mikecase (-- gone --)
Created Revert of Raise exception when devices fail to list tests.
4 years, 8 months ago (2016-04-26 19:58:18 UTC) #1
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:58:34 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698