editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java - Issue 192303002: Support for @DartName and @DartOptional annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java

Issue 192303002: Support for @DartName and @DartOptional annotations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java ('K') | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java ('k') | editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineAnnotationProcessor.java » ('j') | editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineAnnotationProcessor.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java

diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java

index ece0243d40892991c9eff6e59124f4d16fce2f2b..2788414f47b21fd83e5c0ebe1ea7547175e20fdb 100644

--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java

+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java

@@ -2011,6 +2011,9 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {

org.eclipse.jdt.core.dom.Expression javaPairExpr = javaPair.getValue();

Expression dartExpression = translate(javaPairExpr);

Object value = dartExpression.accept(new ConstantEvaluator());

+ if (value == ConstantEvaluator.NOT_A_CONSTANT) {

+ value = dartExpression.toSource();

+ }

parsedAnnotation.put(pairName, value);

}

@@ -2122,6 +2125,7 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {

initializers,

body);

context.putConstructorBinding(constructor, binding);

+ translateAnnotations(constructor, node.modifiers());

return done(constructor);

}

@@ -2136,6 +2140,7 @@ public class SyntaxTranslator extends org.eclipse.jdt.core.dom.ASTVisitor {

for (Iterator<?> I = node.parameters().iterator(); I.hasNext();) {

org.eclipse.jdt.core.dom.SingleVariableDeclaration javaParameter = (org.eclipse.jdt.core.dom.SingleVariableDeclaration) I.next();

SimpleFormalParameter parameter = translate(javaParameter);

+ translateAnnotations(parameter, javaParameter.modifiers());

parameters.add(parameter);

}

parameterList = formalParameterList(parameters);