Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1923023002: [Mac] Pressing unsupported key should not generate keyevents (Closed)

Created:
4 years, 8 months ago by chongz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Pressing unsupported key should not generate keyevents On Mac with an external JIS PC keyboard, pressing "Convert", "NonConvert" and "KanaMode" keys will always produce |NSFlagsChanged| NSEvent with |keycode| == 255. Which will then cause blink to fire two "keydown" events. These three keys do not exist in Apple's Japanese keyboard, and there is no way for us to distinguish them or get any useful information (and it requires hack to mock "keydown"/"keyup"). Safari generates two "keydown"s (with no useful information). Firefox does not generate keyevents for these keys, this CL matches Firefox's bahavior. BUG=601964 Committed: https://crrev.com/bac970b73d720af26ca715c1e001703217e2cfa3 Cr-Commit-Position: refs/heads/master@{#389878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
chongz
Hi asvitkine@, can you take a look at this CL please? (you are the owner ...
4 years, 8 months ago (2016-04-26 20:00:14 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-26 20:03:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923023002/1
4 years, 8 months ago (2016-04-26 20:50:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 21:01:07 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:02:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bac970b73d720af26ca715c1e001703217e2cfa3
Cr-Commit-Position: refs/heads/master@{#389878}

Powered by Google App Engine
This is Rietveld 408576698