Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1923013002: Revert of recipe engine: extract infra-specific paths out of the engine (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Revert of recipe engine: extract infra-specific paths out of the engine (patchset #3 id:40001 of https://codereview.chromium.org/1906323003/ ) Reason for revert: this Cl's untrival roll is breaking skia bots. See https://codereview.chromium.org/1917243002/ Original issue's description: > recipe engine: extract infra-specific paths out of the engine > > BUG=chromium:605919 > > Committed: https://github.com/luci/recipes-py/commit/f712a9271eb999e8b43c48ea9404f4bef393e486 TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605919 Committed: https://github.com/luci/recipes-py/commit/2f86f02a302172514bf282684e0a4aa18b683e41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -62 lines) Patch
M recipe_modules/generator_script/example.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/example.expected/always_run.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/example.expected/basic_python.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/example.expected/malformed_command.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/example.expected/presentation.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/json/example.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/json/example.expected/basic.json View 5 chunks +8 lines, -2 lines 0 comments Download
M recipe_modules/path/__init__.py View 1 chunk +1 line, -4 lines 0 comments Download
M recipe_modules/path/api.py View 3 chunks +10 lines, -4 lines 0 comments Download
M recipe_modules/path/config.py View 2 chunks +48 lines, -3 lines 0 comments Download
M recipe_modules/path/example.py View 4 chunks +17 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/linux.json View 3 chunks +8 lines, -3 lines 0 comments Download
A recipe_modules/path/example.expected/linux_kitchen.json View 1 chunk +47 lines, -0 lines 0 comments Download
A recipe_modules/path/example.expected/linux_swarming.json View 1 chunk +47 lines, -0 lines 0 comments Download
M recipe_modules/path/example.expected/mac.json View 3 chunks +8 lines, -3 lines 0 comments Download
A recipe_modules/path/example.expected/mac_kitchen.json View 1 chunk +47 lines, -0 lines 0 comments Download
A recipe_modules/path/example.expected/mac_swarming.json View 1 chunk +47 lines, -0 lines 0 comments Download
M recipe_modules/path/example.expected/win.json View 3 chunks +8 lines, -3 lines 0 comments Download
A recipe_modules/path/example.expected/win_kitchen.json View 1 chunk +47 lines, -0 lines 0 comments Download
A recipe_modules/path/example.expected/win_swarming.json View 1 chunk +47 lines, -0 lines 0 comments Download
M recipe_modules/platform/example.expected/linux64.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/platform/example.expected/mac64.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/platform/example.expected/win32.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/basic.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_generic.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_git_scheduled.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_scheduled.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/dicts.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/properties/example.expected/lists.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/python/example.expected/basic.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipe_modules/raw_io/example.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/raw_io/example.expected/basic.json View 6 chunks +10 lines, -2 lines 0 comments Download
M recipe_modules/shutil/example.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/shutil/example.expected/basic.json View 18 chunks +41 lines, -20 lines 0 comments Download
M recipe_modules/step/api.py View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/step/example.expected/basic.json View 13 chunks +13 lines, -0 lines 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 11 chunks +11 lines, -0 lines 0 comments Download
M recipe_modules/step/example.expected/exceptional.json View 8 chunks +8 lines, -0 lines 0 comments Download
M recipe_modules/step/example.expected/infra_failure.json View 13 chunks +13 lines, -0 lines 0 comments Download
M recipe_modules/step/example.expected/invalid_access.json View 14 chunks +14 lines, -0 lines 0 comments Download
M recipe_modules/step/example.expected/warning.json View 9 chunks +9 lines, -0 lines 0 comments Download
M recipe_modules/tempfile/example.expected/basic.json View 1 chunk +3 lines, -2 lines 0 comments Download
M recipe_modules/time/example.expected/defaults.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/time/example.expected/seed_and_step.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/uuid/example.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/engine_tests/depend_on/bottom.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/engine_tests/depend_on/no_return.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/engine_tests/functools_partial.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/engine_tests/multi_test_data.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/engine_tests/nonexistent_command.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/engine_tests/subannotations.expected/basic.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipes/engine_tests/trigger.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/example/defer.expected/basic.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipes/example/defer.expected/one_fail.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipes/example/nested.expected/basic.json View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
tandrii(chromium)
Created Revert of recipe engine: extract infra-specific paths out of the engine
4 years, 8 months ago (2016-04-26 18:36:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923013002/1
4 years, 8 months ago (2016-04-26 18:36:52 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 18:37:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/2f86f02a302172514bf282684e0a4aa18b6...

Powered by Google App Engine
This is Rietveld 408576698