third_party/WebKit/Source/core/fetch/ResourceLoader.h - Issue 1923003002: Clear Resource::m_loader in Resource::finish() and Resource::error()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.h

Issue 1923003002: Clear Resource::m_loader in Resource::finish() and Resource::error() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp ('K') | « third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceLoader.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.h b/third_party/WebKit/Source/core/fetch/ResourceLoader.h

index 662fe8d49b112729d6db74be930905a390c26c8e..c618bc9a410285c204ffba8e26a82808928679d6 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.h

@@ -55,7 +55,6 @@ public:

void cancel();

void cancel(const ResourceError&);

- void cancelIfNotFinishing();

Resource* cachedResource() { return m_resource.get(); }

@@ -99,11 +98,8 @@ private:

ConnectionStateReceivedResponse,

ConnectionStateReceivingData,

ConnectionStateFinishedLoading,

- ConnectionStateCanceled,

- ConnectionStateFailed,

Nate Chapin 2016/04/27 19:48:30 Especially in a world where finish/fail/cancel can

ConnectionStateReleased

};

- bool isFinishing() { return m_state >= ConnectionStateFinishedLoading && m_state <= ConnectionStateFailed; }

Member<Resource> m_resource;