Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 1923003002: Clear Resource::m_loader in Resource::finish() and Resource::error() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, comment in background.js Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
index cadf39329c52dd9fbeaa843ca60bb834395db5e7..a63095fa72099c8c3da7e3874aeeb5fb2637950d 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
@@ -166,7 +166,7 @@ TEST(ImageResourceTest, MultipartImage)
ASSERT_EQ(cachedImage->resourceBuffer()->size(), strlen(secondPart) - 1);
// This part finishes. The image is created, callbacks are sent, and the data buffer is cleared.
- cachedImage->finish();
+ cachedImage->loader()->didFinishLoading(nullptr, 0.0, 0);
ASSERT_FALSE(cachedImage->resourceBuffer());
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
@@ -291,9 +291,9 @@ TEST(ImageResourceTest, ReloadIfLoFi)
ASSERT_TRUE(cachedImage->hasImage());
ASSERT_EQ(client.imageChangedCount(), 3);
- cachedImage->responseReceived(resourceResponse, nullptr);
- cachedImage->appendData(reinterpret_cast<const char*>(jpeg.data()), jpeg.size());
- cachedImage->finish();
+ cachedImage->loader()->didReceiveResponse(nullptr, WrappedResourceResponse(resourceResponse), nullptr);
+ cachedImage->loader()->didReceiveData(nullptr, reinterpret_cast<const char*>(jpeg.data()), jpeg.size(), jpeg.size());
+ cachedImage->loader()->didFinishLoading(nullptr, 0.0, jpeg.size());
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
ASSERT_FALSE(cachedImage->getImage()->isNull());

Powered by Google App Engine
This is Rietveld 408576698