Source/web/WebArrayBufferView.cpp - Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebArrayBufferView.cpp

Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased for relanding Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebArrayBufferView.cpp

diff --git a/Source/web/WebArrayBufferView.cpp b/Source/web/WebArrayBufferView.cpp

index ae05b7cdb66bc9120ce96174b2a1e267ac81cc27..044ace416469cdcc0f1376788595bfd0f49b1824 100644

--- a/Source/web/WebArrayBufferView.cpp

+++ b/Source/web/WebArrayBufferView.cpp

@@ -29,7 +29,7 @@

#include "config.h"

#include "WebArrayBufferView.h"

-#include "V8ArrayBufferView.h"

+#include "bindings/v8/custom/V8ArrayBufferViewCustom.h"

#include "wtf/ArrayBufferView.h"

using namespace WTF;

@@ -63,7 +63,7 @@ unsigned WebArrayBufferView::byteLength() const

WebArrayBufferView* WebArrayBufferView::createFromV8Value(v8::Handle<v8::Value> value)

{

- if (!WebCore::V8ArrayBufferView::HasInstanceInAnyWorld(value, v8::Isolate::GetCurrent()))

+ if (!value->IsArrayBufferView())

return 0;

ArrayBufferView* view = WebCore::V8ArrayBufferView::toNative(value->ToObject());

return new WebArrayBufferView(view);

« no previous file with comments | « Source/core/html/canvas/Uint8ClampedArray.idl ('k') | Source/web/WebBindings.cpp » ('j') | no next file with comments »