Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: Source/bindings/v8/custom/V8ArrayBufferViewCustom.cpp

Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased for relanding Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8ArrayBufferViewCustom.h ('k') | Source/bindings/v8/custom/V8BlobCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8ArrayBufferViewCustom.cpp
diff --git a/Source/bindings/v8/custom/V8ArrayBufferViewCustom.cpp b/Source/bindings/v8/custom/V8ArrayBufferViewCustom.cpp
index 367a723897416a8e4d805ab25b16c7d4acc773f6..1d83f4d692a1622b96ac724ca521902c0b6c4a42 100644
--- a/Source/bindings/v8/custom/V8ArrayBufferViewCustom.cpp
+++ b/Source/bindings/v8/custom/V8ArrayBufferViewCustom.cpp
@@ -25,32 +25,63 @@
#include "config.h"
#include "bindings/v8/custom/V8ArrayBufferViewCustom.h"
-#include "V8ArrayBufferViewCustomScript.h"
-#include "bindings/v8/V8HiddenPropertyName.h"
-#include "bindings/v8/V8ScriptRunner.h"
+#include "bindings/v8/custom/V8DataViewCustom.h"
+#include "bindings/v8/custom/V8Float32ArrayCustom.h"
+#include "bindings/v8/custom/V8Float64ArrayCustom.h"
+#include "bindings/v8/custom/V8Int16ArrayCustom.h"
+#include "bindings/v8/custom/V8Int32ArrayCustom.h"
+#include "bindings/v8/custom/V8Int8ArrayCustom.h"
+#include "bindings/v8/custom/V8Uint16ArrayCustom.h"
+#include "bindings/v8/custom/V8Uint32ArrayCustom.h"
+#include "bindings/v8/custom/V8Uint8ArrayCustom.h"
+#include "bindings/v8/custom/V8Uint8ClampedArrayCustom.h"
#include <v8.h>
namespace WebCore {
-bool copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray, uint32_t length, uint32_t offset, v8::Isolate* isolate)
+using namespace WTF;
+
+ArrayBufferView* V8ArrayBufferView::toNative(v8::Handle<v8::Object> object)
{
- v8::Handle<v8::Value> prototype_value = destArray->GetPrototype();
- if (prototype_value.IsEmpty() || !prototype_value->IsObject())
- return false;
- v8::Handle<v8::Object> prototype = prototype_value.As<v8::Object>();
- v8::Handle<v8::Value> value = prototype->GetHiddenValue(V8HiddenPropertyName::typedArrayHiddenCopyMethod());
- if (value.IsEmpty()) {
- String source(reinterpret_cast<const char*>(V8ArrayBufferViewCustomScript_js), sizeof(V8ArrayBufferViewCustomScript_js));
- value = V8ScriptRunner::compileAndRunInternalScript(v8String(source, isolate), isolate);
- prototype->SetHiddenValue(V8HiddenPropertyName::typedArrayHiddenCopyMethod(), value);
- }
- if (value.IsEmpty() || !value->IsFunction())
- return false;
- v8::Handle<v8::Function> copy_method = value.As<v8::Function>();
- v8::Handle<v8::Value> arguments[3] = { srcArray, v8::Uint32::New(length), v8::Uint32::New(offset) };
- V8ScriptRunner::callInternalFunction(copy_method, destArray, WTF_ARRAY_LENGTH(arguments), arguments, isolate);
- return true;
-}
+ ASSERT(object->IsArrayBufferView());
+ void* viewPtr = object->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex);
+ if (viewPtr)
+ return reinterpret_cast<ArrayBufferView*>(viewPtr);
+ if (object->IsUint8Array()) {
+ return V8Uint8Array::toNative(object);
+ }
+ if (object->IsInt8Array()) {
+ return V8Int8Array::toNative(object);
+ }
+ if (object->IsUint16Array()) {
+ return V8Uint16Array::toNative(object);
+ }
+ if (object->IsInt16Array()) {
+ return V8Int16Array::toNative(object);
+ }
+ if (object->IsUint32Array()) {
+ return V8Uint32Array::toNative(object);
+ }
+ if (object->IsInt32Array()) {
+ return V8Int32Array::toNative(object);
+ }
+ if (object->IsFloat32Array()) {
+ return V8Float32Array::toNative(object);
+ }
+ if (object->IsFloat64Array()) {
+ return V8Float64Array::toNative(object);
+ }
+ if (object->IsUint8ClampedArray()) {
+ return V8Uint8ClampedArray::toNative(object);
+ }
+ if (object->IsDataView()) {
+ return V8DataView::toNative(object);
+ }
+ ASSERT_NOT_REACHED();
+ return 0;
}
+
+
+} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8ArrayBufferViewCustom.h ('k') | Source/bindings/v8/custom/V8BlobCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698