Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: LayoutTests/fast/canvas/webgl/array-unit-tests.html

Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased for relanding Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/webgl/array-unit-tests.html
diff --git a/LayoutTests/fast/canvas/webgl/array-unit-tests.html b/LayoutTests/fast/canvas/webgl/array-unit-tests.html
index 30fd9614fcece32313644b51015e767d99f96f64..b182516e6f5f9f725fbdf1b4453e6f8f4f48e9a1 100644
--- a/LayoutTests/fast/canvas/webgl/array-unit-tests.html
+++ b/LayoutTests/fast/canvas/webgl/array-unit-tests.html
@@ -123,9 +123,12 @@ function testInheritanceHierarchy() {
} catch (e) {
testPassed('ArrayBufferView has [NoInterfaceObject] extended attribute and was (correctly) not defined');
}
-
- // There is currently only one kind of view that inherits from another
- shouldBe('new Uint8ClampedArray(1) instanceof Uint8Array', 'true');
+
+ // There is currently only one kind of view that inherits from another
+ // Uint8ClampedArray inherited from Uint8Array in earlier versions
+ // of the typed array specification. Since this is no longer the
+ // case, assert the new behavior.
+ shouldBe('new Uint8ClampedArray(1) instanceof Uint8Array', 'false');
}
//
@@ -648,19 +651,6 @@ function testConstructionWithUnalignedLength(type, name, elementSizeInBytes) {
}
}
-function testConstructionOfHugeArray(type, name, sz) {
- if (sz == 1)
- return;
- try {
- // Construction of huge arrays must fail because byteLength is
- // an unsigned long
- array = new type(3000000000);
- testFailed("Construction of huge " + name + " should throw exception");
- } catch (e) {
- testPassed("Construction of huge " + name + " threw exception");
- }
-}
-
function testConstructionWithBothArrayBufferAndLength(type, name, elementSizeInBytes) {
var bufByteLength = 1000 * elementSizeInBytes;
var buf = new ArrayBuffer(bufByteLength);
@@ -1003,7 +993,6 @@ function runTests() {
testConstructionWithNegativeOutOfRangeValues(type, name);
testConstructionWithUnalignedOffset(type, name, testCase.elementSizeInBytes);
testConstructionWithUnalignedLength(type, name, testCase.elementSizeInBytes);
- testConstructionOfHugeArray(type, name, testCase.elementSizeInBytes);
testConstructionWithBothArrayBufferAndLength(type, name, testCase.elementSizeInBytes);
testConstructionWithSubPortionOfArrayBuffer(type, name, testCase.elementSizeInBytes);
testSubarrayWithOutOfRangeValues(type, name, testCase.elementSizeInBytes);

Powered by Google App Engine
This is Rietveld 408576698