Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: LayoutTests/fast/canvas/webgl/array-unit-tests.html

Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Typo fixed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/webgl/array-unit-tests.html
diff --git a/LayoutTests/fast/canvas/webgl/array-unit-tests.html b/LayoutTests/fast/canvas/webgl/array-unit-tests.html
index 30fd9614fcece32313644b51015e767d99f96f64..99a9f5ab60f686cf6df652503fb1f295d796fbfb 100644
--- a/LayoutTests/fast/canvas/webgl/array-unit-tests.html
+++ b/LayoutTests/fast/canvas/webgl/array-unit-tests.html
@@ -123,9 +123,6 @@ function testInheritanceHierarchy() {
} catch (e) {
testPassed('ArrayBufferView has [NoInterfaceObject] extended attribute and was (correctly) not defined');
}
-
- // There is currently only one kind of view that inherits from another
- shouldBe('new Uint8ClampedArray(1) instanceof Uint8Array', 'true');
}
//
@@ -344,8 +341,8 @@ function testOffsetsAndSizes(type, name, elementSizeInBytes) {
running('test ' + name + ' OffsetsAndSizes');
try {
var len = 10;
- assertEq('type.BYTES_PER_ELEMENT', elementSizeInBytes, type.BYTES_PER_ELEMENT);
var array = new type(len);
+ assertEq('array.BYTES_PER_ELEMENT', elementSizeInBytes, array.BYTES_PER_ELEMENT);
assert('array.buffer', array.buffer);
assertEq('array.byteOffset', 0, array.byteOffset);
assertEq('array.length', len, array.length);
@@ -647,7 +644,7 @@ function testConstructionWithUnalignedLength(type, name, elementSizeInBytes) {
}, "Construction of " + name + " with unaligned length");
}
}
-
+/*
function testConstructionOfHugeArray(type, name, sz) {
if (sz == 1)
return;
@@ -660,6 +657,7 @@ function testConstructionOfHugeArray(type, name, sz) {
testPassed("Construction of huge " + name + " threw exception");
}
}
+*/
function testConstructionWithBothArrayBufferAndLength(type, name, elementSizeInBytes) {
var bufByteLength = 1000 * elementSizeInBytes;
@@ -1003,7 +1001,7 @@ function runTests() {
testConstructionWithNegativeOutOfRangeValues(type, name);
testConstructionWithUnalignedOffset(type, name, testCase.elementSizeInBytes);
testConstructionWithUnalignedLength(type, name, testCase.elementSizeInBytes);
- testConstructionOfHugeArray(type, name, testCase.elementSizeInBytes);
+// testConstructionOfHugeArray(type, name, testCase.elementSizeInBytes);
jochen (gone - plz use gerrit) 2013/07/16 08:53:57 can you move this to a separate layout test and ma
Dmitry Lomov (no reviews) 2013/07/16 13:05:48 Done.
testConstructionWithBothArrayBufferAndLength(type, name, testCase.elementSizeInBytes);
testConstructionWithSubPortionOfArrayBuffer(type, name, testCase.elementSizeInBytes);
testSubarrayWithOutOfRangeValues(type, name, testCase.elementSizeInBytes);

Powered by Google App Engine
This is Rietveld 408576698