LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js - Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/js/constructor-length-expected.txt ('K') | « LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('k') | Source/bindings/bindings.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

diff --git a/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js b/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

index 09c244d72b820d9e5d90d88d8b1dac1bed27ec11..19d0d2b63669cc4c52a15600029b44b36a6c19aa 100644

--- a/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

+++ b/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

@@ -50,10 +50,6 @@ descriptorShouldBe("document.getElementsByTagName('div')", "'length'", {writable

descriptorShouldBe("document.getElementsByTagName('div')", "0", {writable: false, enumerable: true, configurable: false, value:"document.getElementsByTagName('div')[0]"});

descriptorShouldBe("document.getElementsByClassName('pass')", "0", {writable: false, enumerable: true, configurable: false, value:"document.getElementsByClassName('pass')[0]"});

descriptorShouldBe("document.getElementsByClassName('pass')", "'length'", {writable: false, enumerable: true, configurable: false, value:"document.getElementsByClassName('pass').length"});

-var canvas = document.createElement("canvas");

-var canvasPixelArray = canvas.getContext("2d").createImageData(10,10).data;

-descriptorShouldBe("canvasPixelArray", "'length'", {writable: false, enumerable: true, configurable: false, value:"canvasPixelArray.length"});

Dmitry Lomov (no reviews) 2013/07/15 16:58:05 These properties are not object's own - they are o

-descriptorShouldBe("canvasPixelArray", "0", {writable: true, enumerable: true, configurable: false, value:"canvasPixelArray[0]"});

var select = document.createElement("select");

select.innerHTML = "<option>foo</option>";

descriptorShouldBe("select", "'length'", {writable: false, enumerable: true, configurable: false, value:"select.length"});