Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/bindings/v8/custom/V8DataViewCustom.cpp

Issue 19230002: Use V8 implementation of TypedArrays and DataView in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased for relanding Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/html/canvas/DataView.h" 27 #include "bindings/v8/custom/V8DataViewCustom.h"
28 28
29 #include "V8DataView.h"
30 #include "bindings/v8/V8Binding.h" 29 #include "bindings/v8/V8Binding.h"
31 #include "bindings/v8/custom/V8ArrayBufferViewCustom.h" 30 #include "bindings/v8/custom/V8ArrayBufferViewCustom.h"
31 #include "core/html/canvas/DataView.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 void V8DataView::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& ar gs) 35 static void initializeScriptWrappableForInterface(DataView* object)
36 { 36 {
37 if (!args.Length()) { 37 if (ScriptWrappable::wrapperCanBeStoredInObject(object))
38 // see constructWebGLArray -- we don't seem to be able to distingish bet ween 38 ScriptWrappable::setTypeInfoInObject(object, &V8DataView::info);
39 // 'new DataView()' and the call used to construct the cached DataView o bject. 39 else
40 RefPtr<DataView> dataView = DataView::create(0); 40 ASSERT_NOT_REACHED();
41 v8::Handle<v8::Object> wrapper = args.Holder();
42 V8DOMWrapper::associateObjectWithWrapper<V8DataView>(dataView.release(), &info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);
43 args.GetReturnValue().Set(wrapper);
44 return;
45 }
46 if (args[0]->IsNull() || !V8ArrayBuffer::HasInstance(args[0], args.GetIsolat e(), worldType(args.GetIsolate()))) {
47 throwTypeError(args.GetIsolate());
48 return;
49 }
50 constructWebGLArrayWithArrayBufferArgument<DataView, char, V8DataView>(args, &info, v8::kExternalByteArray, false);
51 }
52
53 // FIXME: Don't need this override.
54 v8::Handle<v8::Object> wrap(DataView* impl, v8::Handle<v8::Object> creationConte xt, v8::Isolate* isolate)
55 {
56 ASSERT(impl);
57 return V8DataView::createWrapper(impl, creationContext, isolate);
58 } 41 }
59 42
60 } // namespace WebCore 43 } // namespace WebCore
44
45 // In ScriptWrappable::init, the use of a local function declaration has an issu e on Windows:
46 // the local declaration does not pick up the surrounding namespace. Therefore, we provide this function
47 // in the global namespace.
48 // (More info on the MSVC bug here: http://connect.microsoft.com/VisualStudio/fe edback/details/664619/the-namespace-of-local-function-declarations-in-c)
49 void webCoreInitializeScriptWrappableForInterface(WebCore::DataView* object)
50 {
51 WebCore::initializeScriptWrappableForInterface(object);
52 }
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8DataViewCustom.h ('k') | Source/bindings/v8/custom/V8Float32ArrayCustom.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698