Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5971)

Unified Diff: chrome/browser/global_keyboard_shortcuts_mac_unittest.mm

Issue 1922993002: Remove the backspace/shift+backspace navigating the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_mac.mm ('k') | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
diff --git a/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm b/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
index df0e4ebe0d67c6df30db2bdf563051e4ae51158e..2359d8a881fd668b458ef4242e6bd9a47856bccc 100644
--- a/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
+++ b/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
@@ -29,13 +29,11 @@ TEST(GlobalKeyboardShortcuts, ShortcutsToWindowCommand) {
EXPECT_EQ(cmd_num, it->chrome_command);
}
- // Test that cmd-left and backspace are not window-level commands (else they
- // would be invoked even if e.g. the omnibox had focus, where they really
+ // Test that cmd-left is not a window-level command (else it
+ // would be invoked even if e.g. the omnibox had focus, where it really
// should have text editing functionality).
EXPECT_EQ(-1, CommandForWindowKeyboardShortcut(
true, false, false, false, kVK_LeftArrow, 0));
- EXPECT_EQ(-1, CommandForWindowKeyboardShortcut(
- false, false, false, false, kVK_Delete, 0));
// Test that Cmd-'{' and Cmd-'}' are interpreted as IDC_SELECT_NEXT_TAB
// and IDC_SELECT_PREVIOUS_TAB regardless of the virtual key code values.
« no previous file with comments | « chrome/browser/global_keyboard_shortcuts_mac.mm ('k') | chrome/browser/ui/views/accelerator_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698