Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922983002: sheriff_o_matic: Add error if ajax request fails. (Closed)

Created:
4 years, 7 months ago by martiniss
Modified:
4 years, 7 months ago
Reviewers:
seanmccullough
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

sheriff_o_matic: Add error if ajax request fails. BUG=606611 Committed: https://chromium.googlesource.com/infra/infra/+/aa64dd6b521a466a8a5ab68a982703ee13bf9c25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M appengine/sheriff_o_matic/model/ct-failure-group.html View 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/sheriff_o_matic/ui/ct-failure-card-buttons.html View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
martiniss
PTAL
4 years, 7 months ago (2016-04-26 18:26:37 UTC) #2
seanmccullough
lgtm
4 years, 7 months ago (2016-04-27 17:47:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922983002/1
4 years, 7 months ago (2016-04-27 17:47:37 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 17:51:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/aa64dd6b521a466a8a5ab68a98270...

Powered by Google App Engine
This is Rietveld 408576698