Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1922953002: Revert "VM: Improve phi-elimination to improve code inside of try-catch." (Closed)

Created:
4 years, 8 months ago by Florian Schneider
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Improve phi-elimination to improve code inside of try-catch." This reverts commit 6d537d7e61683611c6d0b42fb3f559313e47f0e8. Need more time to investigate test failures that occur with this CL. TBR=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6ff337f724c936ecb8ef9331dfaf3a96bbaecffb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 3 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
tbr
4 years, 8 months ago (2016-04-26 15:24:20 UTC) #1
Florian Schneider
Committed patchset #1 (id:1) manually as 6ff337f724c936ecb8ef9331dfaf3a96bbaecffb (presubmit successful).
4 years, 8 months ago (2016-04-26 15:24:41 UTC) #3
Vyacheslav Egorov (Google)
4 years, 8 months ago (2016-04-27 09:54:48 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698