Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 192293007: Extend the sample rates that Pepper should support. (Closed)

Created:
6 years, 9 months ago by no longer working on chromium
Modified:
6 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Extend the sample rates that Pepper should support. Chrome actually supports a wide range of sample rates for the capture audio. So Pepper should also do this. Also, since getUserMedia soon has APM in chrome, that means Pepper will get post-processed data whose sample rate will be 16000 on Android and 32000 on Desktop. In the future it will be 48000. NOTRY=true BUG=264611 TEST=browser_tests --gtest_filter="*PPAPINaClGLibcTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256206

Patch Set 1 : #

Total comments: 6

Patch Set 2 : fixed the comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M content/renderer/pepper/pepper_media_stream_audio_track_host.cc View 1 2 chunks +19 lines, -9 lines 0 comments Download
M ppapi/api/ppb_audio_buffer.idl View 1 chunk +7 lines, -1 line 0 comments Download
M ppapi/c/ppb_audio_buffer.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ppapi/tests/test_media_stream_audio_track.cc View 1 2 chunks +20 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_display_color_profile_private_thunk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
no longer working on chromium
Hi Yuzhu, please review this CL, and also please help add other reviewer if the ...
6 years, 9 months ago (2014-03-10 19:30:51 UTC) #1
yzshen1
LGTM https://codereview.chromium.org/192293007/diff/20001/content/renderer/pepper/pepper_media_stream_audio_track_host.cc File content/renderer/pepper/pepper_media_stream_audio_track_host.cc (right): https://codereview.chromium.org/192293007/diff/20001/content/renderer/pepper/pepper_media_stream_audio_track_host.cc#newcode41 content/renderer/pepper/pepper_media_stream_audio_track_host.cc:41: return PP_AUDIOBUFFER_SAMPLERATE_UNKNOWN; I think we don't need this ...
6 years, 9 months ago (2014-03-10 21:13:10 UTC) #2
no longer working on chromium
Thanks. https://codereview.chromium.org/192293007/diff/20001/content/renderer/pepper/pepper_media_stream_audio_track_host.cc File content/renderer/pepper/pepper_media_stream_audio_track_host.cc (right): https://codereview.chromium.org/192293007/diff/20001/content/renderer/pepper/pepper_media_stream_audio_track_host.cc#newcode41 content/renderer/pepper/pepper_media_stream_audio_track_host.cc:41: return PP_AUDIOBUFFER_SAMPLERATE_UNKNOWN; On 2014/03/10 21:13:11, yzshen1 wrote: > ...
6 years, 9 months ago (2014-03-11 09:07:05 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-11 09:07:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/192293007/40001
6 years, 9 months ago (2014-03-11 09:08:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 11:35:20 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-11 11:35:21 UTC) #7
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-11 11:38:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/192293007/40001
6 years, 9 months ago (2014-03-11 11:39:43 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 11:41:38 UTC) #10
Message was sent while issue was closed.
Change committed as 256206

Powered by Google App Engine
This is Rietveld 408576698