Source/core/dom/shadow/ComposedTreeWalker.cpp - Issue 192293002: Use new is*Element() helper functions in DOM code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ComposedTreeWalker.cpp

Issue 192293002: Use new is*Element() helper functions in DOM code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add is*Element(PassRefPtr) helper Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/build/scripts/templates/ElementTypeHelpers.h.tmpl ('K') | « Source/core/dom/VisitedLinkState.cpp ('k') | Source/core/dom/shadow/ElementShadow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/shadow/ComposedTreeWalker.cpp

diff --git a/Source/core/dom/shadow/ComposedTreeWalker.cpp b/Source/core/dom/shadow/ComposedTreeWalker.cpp

index 29a180f903877a09868f190f747132aba2c2e592..55390f60d295fe2dd306d8cab292e7ac629dc59b 100644

--- a/Source/core/dom/shadow/ComposedTreeWalker.cpp

+++ b/Source/core/dom/shadow/ComposedTreeWalker.cpp

@@ -72,7 +72,7 @@ Node* ComposedTreeWalker::traverseNode(const Node* node, TraversalDirection dire

const InsertionPoint* insertionPoint = toInsertionPoint(node);

if (Node* found = traverseDistributedNodes(direction == TraversalDirectionForward ? insertionPoint->first() : insertionPoint->last(), insertionPoint, direction))

return found;

- ASSERT(node->hasTagName(HTMLNames::shadowTag) || (node->hasTagName(HTMLNames::contentTag) && !node->hasChildren()));

+ ASSERT(isHTMLShadowElement(node) || (isHTMLContentElement(node) && !node->hasChildren()));

return 0;

}

« Source/build/scripts/templates/ElementTypeHelpers.h.tmpl ('K') | « Source/core/dom/VisitedLinkState.cpp ('k') | Source/core/dom/shadow/ElementShadow.cpp » ('j') | no next file with comments »