Source/core/dom/RenderTreeBuilder.cpp - Issue 192293002: Use new is*Element() helper functions in DOM code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/RenderTreeBuilder.cpp

Issue 192293002: Use new is*Element() helper functions in DOM code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add is*Element(PassRefPtr) helper Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/RenderTreeBuilder.cpp

diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp

index 168fcce88be4aa17d155cf9627e9d97dbd9d100f..bb52e93f7887955aeff8327bfd0b24bc111bf499 100644

--- a/Source/core/dom/RenderTreeBuilder.cpp

+++ b/Source/core/dom/RenderTreeBuilder.cpp

@@ -80,7 +80,7 @@ bool RenderTreeBuilder::shouldCreateRenderer() const

return false;

if (m_node->isSVGElement()) {

// SVG elements only render when inside <svg>, or if the element is an <svg> itself.

- if (!m_node->hasTagName(SVGNames::svgTag) && !m_renderingParent->isSVGElement())

+ if (!isSVGSVGElement(*m_node) && !m_renderingParent->isSVGElement())

return false;

if (!toSVGElement(m_node)->isValid())

return false;