Use new is*Element() helper functions in DOM code

Source/build/scripts/templates/ElementTypeHelpers.h.tmpl

Index: Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
diff --git a/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl b/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
index f4c6b20cf3ec1d23c360cb4e3d8f95bb4f927e2f..fb22148f6110b9ad6bbc13b252e4cfcfa7af9766 100644
--- a/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
+++ b/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
@@ -27,6 +27,7 @@ inline bool is{{tag.interface}}(const Element& element) {
     return element.hasTagName({{namespace}}Names::{{tag|symbol}}Tag);
 }
 inline bool is{{tag.interface}}(const Element* element) { return element && is{{tag.interface}}(*element); }
+template<typename T> inline bool is{{tag.interface}}(const RefPtr<T>& node) { return is{{tag.interface}}(node.get()); }

[adamk, 2014/03/10 18:23:24]

This seems possibly-dangerous, as passing a PassRefPtr into this method will
null it out (due to the RefPtr(PassRefPtr) implicit constructor), so the
conversion from

node->hasTagName(fooTag)

to

isHTMLFooElement(node)

will have a difference in behavior. I think you can make this safe at the cost
of an extra ref by using const PassRefPtr& as the type.

[Inactive, 2014/03/10 18:28:29]

You are right, I believe we had the exact same discussion on the Node comparison
operators. I actually importing this line from the
DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION() macro without paying enough attention. I
will fix this here and in the Node macro and reupload.

 inline bool is{{tag.interface}}(const Node& node) { return node.isElementNode() ? is{{tag.interface}}(toElement(node)) : false; }
 inline bool is{{tag.interface}}(const Node* node) { return node && node->isElementNode() ? is{{tag.interface}}(*toElement(node)) : false; }
 template <> inline bool isElementOfType<const {{tag.interface}}>(const Element& element) { return is{{tag.interface}}(element); }