Have MessagePort use Oilpan-based weak pointers.

Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=haraken
BUG=522357
Committed: https://crrev.com/ab9d5d4a1823551e779ad44359d94ccce8add6f2
Cr-Commit-Position: refs/heads/master@{#390105}

[sof, 2016-04-27 13:50:35]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-04-27 13:50:36]

please take a look.

https://codereview.chromium.org/1922923003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/MessagePort.h (right):

https://codereview.chromium.org/1922923003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/MessagePort.h:124:
OwnPtr<WebMessagePortChannel> m_entangledChannel;
Note: I'm considering making MessagePort eagerly finalized independently of this
WeakPtr<> issue -- the current delayed close()ing looks shaky.

[sof, 2016-04-27 13:52:16]

Description was changed from

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is tkane _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=
BUG=522357
==========

to

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=
BUG=522357
==========

[sof, 2016-04-27 13:56:00]

Description was changed from

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=
BUG=522357
==========

to

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=
BUG=522357
==========

[haraken, 2016-04-27 14:54:34]

LGTM

[sof, 2016-04-27 15:00:26]

Description was changed from

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=
BUG=522357
==========

to

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=haraken
BUG=522357
==========

[sof, 2016-04-27 15:46:26]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-04-27 15:46:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922923003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922923003/1

[commit-bot: I haz the power, 2016-04-27 16:51:49]

Description was changed from

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=haraken
BUG=522357
==========

to

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=haraken
BUG=522357
==========

[commit-bot: I haz the power, 2016-04-27 16:51:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:10:41]

Patchset 1 (id:??) landed as
https://crrev.com/ab9d5d4a1823551e779ad44359d94ccce8add6f2
Cr-Commit-Position: refs/heads/master@{#390105}

[commit-bot: I haz the power, 2016-04-30 17:50:28]

Description was changed from

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=haraken
BUG=522357
==========

to

==========
Have MessagePort use Oilpan-based weak pointers.

Using WeakPtr<>/WeakPtrFactory<> with Oilpan heap objects is problematic
in the face of lazy sweeping, WeakPtr<> references aren't cleared until
the finalizer runs. Should a posted task (like for MessagePort) run
before that happens, it might then access already finalized objects that
MessagePort refers to.

Hence WeakPtr<>s should not be used for Oilpan objects unless extra
finalization care is taken _and_ the object depends on WeakPtrFactory<>'s
support for explicit revocation. Use Oilpan weak references instead.

Also clear out various redundant WeakPtr.h includes throughout Blink.

R=haraken
BUG=522357

Committed: https://crrev.com/ab9d5d4a1823551e779ad44359d94ccce8add6f2
Cr-Commit-Position: refs/heads/master@{#390105}
==========