third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h - Issue 1922923002: bluetooth: Move requestDevice to mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h

Issue 1922923002: bluetooth: Move requestDevice to mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-separate-tests-request-device

Patch Set: Remove debug log Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h ('k') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('j') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h

diff --git a/third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h b/third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h

index f482c4c826dd1c1520b162e71c55fd6966e44f14..ade32f5a46af4fd6432e0c2d3c55d735da59dd51 100644

--- a/third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h

+++ b/third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h

@@ -16,8 +16,13 @@ struct WebBluetoothScanFilter {

WebBluetoothScanFilter() { }

WebVector<WebString> services;

+ // We don't allow empty services or namePrefix but we do allow

+ // an empty name so we can't use name.isEmpty() to know if

+ // the filter contains a name or not.

+ bool hasName;

WebString name;

WebString namePrefix;

Jeffrey Yasskin 2016/05/13 04:41:59 Remove this blank line.

ortuno 2016/05/13 20:11:18 Done.

};

// Contains members corresponding to RequestDeviceOptions members as