bluetooth: Move requestDevice to mojo

content/browser/renderer_host/render_process_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <queue>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/observer_list.h"
 #include "base/process/process.h"
 #include "base/synchronization/waitable_event.h"
 #include "build/build_config.h"
+#include "content/browser/bluetooth/bluetooth_adapter_factory_wrapper.h"
 #include "content/browser/child_process_launcher.h"
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/power_monitor_message_broadcaster.h"
 #include "content/common/content_export.h"
 #include "content/common/mojo/service_registry_impl.h"
 #include "content/public/browser/render_process_host.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_platform_file.h"
 #include "mojo/public/cpp/bindings/interface_ptr.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 #include "ui/gl/gpu_switching_observer.h"
 
 namespace base {
 class CommandLine;
 class MessageLoop;
 }
 
 namespace gfx {
 class Size;
 }
 
 namespace IPC {
 class ChannelMojoHost;
 }
 
 namespace content {
 class AudioInputRendererHost;
 class AudioRendererHost;
-class BluetoothDispatcherHost;
 class BrowserCdmManager;
 class BrowserDemuxerAndroid;
 class InProcessChildThreadParams;
 class MessagePortMessageFilter;
 class MojoApplicationHost;
 class MojoChildConnection;
 class NotificationMessageFilter;
 #if defined(ENABLE_WEBRTC)
 class P2PSocketDispatcherHost;
 #endif
@@ skipping 193 matching lines @@
     return notification_message_filter_.get();
   }
 
   void set_is_for_guests_only_for_testing(bool is_for_guests_only) {
     is_for_guests_only_ = is_for_guests_only;
   }
 
   void GetAudioOutputControllers(
       const GetAudioOutputControllersCallback& callback) const override;
 
-  BluetoothDispatcherHost* GetBluetoothDispatcherHost();
+  BluetoothAdapterFactoryWrapper& GetBluetoothAdapterFactoryWrapper();

[ncarter (slow), 2016/05/25 21:19:18]

This ought to be a pointer, not a ref.

[Jeffrey Yasskin, 2016/05/25 21:31:02]

How come? Your comment is often a misunderstanding of the "no non-const
reference arguments" rule at
https://google.github.io/styleguide/cppguide.html#Reference_Arguments, which
doesn't say anything about return types, but you may have another reason.

I prefer a reference return because it's never null.

[ortuno, 2016/05/26 20:31:01]

I agree with jyasskin. The reference indicates users of the function that this
value will never be null.

[ncarter (slow), 2016/05/26 21:47:35]

I agree with you, that it isn't prohibited by the style guide. It struck me as
odd because the "ref means it can't be null" convention is uncommon in content/.
For example, this class has a bunch of pointer-valued function that can never be
null. They don't use references to indicate this. Doing it here seems
inconsistent with the surrounding code in content/browser.

I see:

https://goo.gl/6o1YMQ 487 pointer valued functions
https://goo.gl/W2jnWo 43 ref-valued functions
https://goo.gl/4pWAmQ of which 32 are const ref

Leaving 11 cases where we do this, vs 487 cases where we don't.

Having said that, this is the sort of style debate I absolutely loathe. You can
do it if it's really important to you.

[ncarter (slow), 2016/05/26 22:02:34]

Whoops, that last bit possibly came across too passive-agressive. What I mean
is: if you're not swayed by the consistency argument, then go ahead with the
non-const ref: the style guide is the ultimate arbiter here, and it says this is
legal.

[ortuno, 2016/05/27 02:53:25]

Consistency makes sense. I've changed the function to return a pointer.

 
 #if defined(OS_POSIX) && !defined(OS_ANDROID) && !defined(OS_MACOSX)
   // Launch the zygote early in the browser startup.
   static void EarlyZygoteLaunch();
 #endif  // defined(OS_POSIX) && !defined(OS_ANDROID) && !defined(OS_MACOSX)
 
   void RecomputeAndUpdateWebKitPreferences();
 
  protected:
   // A proxy for our IPC::Channel that lives on the IO thread.
@@ skipping 185 matching lines @@
   // through RenderProcessHostObserver::RenderProcessExited.
   bool within_process_died_observer_;
 
   // Forwards power state messages to the renderer process.
   PowerMonitorMessageBroadcaster power_monitor_broadcaster_;
 
   scoped_refptr<AudioRendererHost> audio_renderer_host_;
 
   scoped_refptr<AudioInputRendererHost> audio_input_renderer_host_;
 
-  scoped_refptr<BluetoothDispatcherHost> bluetooth_dispatcher_host_;
+  BluetoothAdapterFactoryWrapper bluetooth_adapter_factory_wrapper_;
 
 #if defined(OS_ANDROID)
   scoped_refptr<BrowserDemuxerAndroid> browser_demuxer_android_;
 #endif
 
 #if defined(ENABLE_WEBRTC)
   scoped_refptr<P2PSocketDispatcherHost> p2p_socket_dispatcher_host_;
 
   // Must be accessed on UI thread.
   std::vector<int> aec_dump_consumers_;
@@ skipping 33 matching lines @@
   mojo::ScopedMessagePipeHandle in_process_renderer_handle_;
 
   base::WeakPtrFactory<RenderProcessHostImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderProcessHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_PROCESS_HOST_IMPL_H_