Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1922903003: Postmortem: export DATA_CONSTANT (Closed)

Created:
4 years, 8 months ago by fedor.indutny
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Postmortem: export DATA_CONSTANT Useful for inspecting constant fields in objects. BUG= R=machenbach Committed: https://crrev.com/8eda85d54edfa9fec95b22c9afdac0560e72eae1 Cr-Commit-Position: refs/heads/master@{#35826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fedor.indutny
4 years, 8 months ago (2016-04-26 21:59:49 UTC) #1
Michael Achenbach
lgtm - rubberstamp
4 years, 8 months ago (2016-04-27 08:04:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922903003/1
4 years, 7 months ago (2016-04-27 15:29:13 UTC) #5
fedor.indutny
Thank you, Michael!
4 years, 7 months ago (2016-04-27 15:29:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 15:50:14 UTC) #7
fedor.indutny
Michael, May I ask you if it could be possible to backport this to v5? ...
4 years, 7 months ago (2016-04-27 16:18:46 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8eda85d54edfa9fec95b22c9afdac0560e72eae1
Cr-Commit-Position: refs/heads/master@{#35826}

Powered by Google App Engine
This is Rietveld 408576698