Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1922883002: Remove unused code in VulkanSwapChain. (Closed)

Created:
4 years, 7 months ago by sohanjg
Modified:
4 years, 7 months ago
Reviewers:
David Yen, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code in VulkanSwapChain. BUG=582558 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/942905439e5f5c77b9868e373841df8bb7cdff97 Cr-Commit-Position: refs/heads/master@{#389831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M gpu/vulkan/vulkan_swap_chain.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sohanjg
Please take a look, i hope image_subresource_range was not kept for future use in SwapBuffers ...
4 years, 7 months ago (2016-04-26 14:37:07 UTC) #3
piman
lgtm
4 years, 7 months ago (2016-04-26 16:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922883002/1
4 years, 7 months ago (2016-04-26 18:05:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 18:58:33 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 19:01:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/942905439e5f5c77b9868e373841df8bb7cdff97
Cr-Commit-Position: refs/heads/master@{#389831}

Powered by Google App Engine
This is Rietveld 408576698