Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922873004: Add script for benchmarking with --runtime-call-stats (Closed)

Created:
4 years, 8 months ago by nickie
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add script for benchmarking with --runtime-call-stats R=cbruni@chromium.org BUG= LOG=N Committed: https://crrev.com/1d941a4466b9ae3a3968977bf3285fc05ccc4851 Cr-Commit-Position: refs/heads/master@{#36070}

Patch Set 1 #

Patch Set 2 : Fix for redirecting pages which print multiple statistics #

Patch Set 3 : Remove calculated sum from JSON file #

Total comments: 1

Patch Set 4 : Update websites and chrome flags #

Total comments: 1

Patch Set 5 : Support for webpagereplay, timeout per page #

Patch Set 6 : Bug fix with timeouts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -0 lines) Patch
A tools/callstats.py View 1 2 3 4 5 1 chunk +524 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
nickie
4 years, 8 months ago (2016-04-26 16:15:36 UTC) #1
Camillo Bruni
can you update the hardcoded urls with the ones specified in the OKRs?
4 years, 7 months ago (2016-04-27 11:47:55 UTC) #2
nickie
Websites updated. https://codereview.chromium.org/1922873004/diff/40001/tools/runtime-call-stats.py File tools/runtime-call-stats.py (right): https://codereview.chromium.org/1922873004/diff/40001/tools/runtime-call-stats.py#newcode89 tools/runtime-call-stats.py:89: "--disk-cache-size=1", I'm removing this option, as some ...
4 years, 7 months ago (2016-04-27 12:22:16 UTC) #3
Camillo Bruni
lgtm
4 years, 7 months ago (2016-04-27 13:21:06 UTC) #4
nickie
I'll do some automation for replay before landing this, it seems easy. https://codereview.chromium.org/1922873004/diff/60001/tools/runtime-call-stats.py File tools/runtime-call-stats.py ...
4 years, 7 months ago (2016-04-27 15:08:15 UTC) #5
Camillo Bruni
lgtm again, let's land this and improve it in the tree.
4 years, 7 months ago (2016-05-06 09:50:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922873004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922873004/100001
4 years, 7 months ago (2016-05-06 09:51:56 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-06 10:17:28 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 10:18:24 UTC) #11
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/1d941a4466b9ae3a3968977bf3285fc05ccc4851
Cr-Commit-Position: refs/heads/master@{#36070}

Powered by Google App Engine
This is Rietveld 408576698