Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1922863003:
Don't pull in mojo on iOS. (Closed)
|
Created:
4 years, 7 months ago by justincohen Modified:
4 years, 7 months ago CC:
chromium-reviews, smut Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't pull in mojo on iOS.
This ended up pulling in a bunch of v8 code that doesn't work with the
ninja-xcode bindings.
BUG=
Committed: https://crrev.com/0101c9fd370c1d451439a170dd2200124fe54ec7
Cr-Commit-Position: refs/heads/master@{#389888}
Patch Set 1 #
Messages
Total messages: 21 (8 generated)
justincohen@chromium.org changed reviewers: + rohitrao@chromium.org, sdefresne@chromium.org
lgtm
Over to brettw for OWNERS. This is unintentionally pulling in a quite of extra code for iOS downstream.
smut@ can we add xcode-ninja to one of the upstream and downstream bots GYP_GENERATORS to catch these errors?
justincohen@chromium.org changed reviewers: + brettw@chromium.org
lgtm
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922863003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't pull in mojo on iOS. This ended up pulling in a bunch of v8 code that doesn't work with the ninja-xcode bindings. BUG= ========== to ========== Don't pull in mojo on iOS. This ended up pulling in a bunch of v8 code that doesn't work with the ninja-xcode bindings. BUG= Committed: https://crrev.com/0101c9fd370c1d451439a170dd2200124fe54ec7 Cr-Commit-Position: refs/heads/master@{#389888} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0101c9fd370c1d451439a170dd2200124fe54ec7 Cr-Commit-Position: refs/heads/master@{#389888} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
