Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1922853003:
Do not globally register drawables in test code (Closed)
DescriptionDo not globally register drawables in test code
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922853003
Committed: https://skia.googlesource.com/skia/+/002c92bcbf3baf6689b0c1ece11eb01c32ac770a
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Do not globally register drawables in test code BUG=skia: ========== to ========== Do not globally register drawables in test code BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
msarett@google.com changed reviewers: + reed@google.com, stephana@google.com
TSAN bot failures are occurring because FlattenDrawableTest.cpp adds flattenables to the global registry, and another test (FlattenFactoryToName) uses the global registry (possibly while it is being modified). https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX... We want to move away from using the global registry towards using custom unflatten procs on the SkReadBuffer. So let's go ahead and change the test to register custom procs on the SkReadBuffer, rather than registering globally.
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922853003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Do not globally register drawables in test code BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Do not globally register drawables in test code TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922853003/1
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/1922853003/diff/1/tests/FlattenDrawableTest.cpp File tests/FlattenDrawableTest.cpp (right): https://codereview.chromium.org/1922853003/diff/1/tests/FlattenDrawableTest.c... tests/FlattenDrawableTest.cpp:257: DEF_TEST(FlattenCustomDrawable, r) { Does this make this test moot?
https://codereview.chromium.org/1922853003/diff/1/tests/FlattenDrawableTest.cpp File tests/FlattenDrawableTest.cpp (right): https://codereview.chromium.org/1922853003/diff/1/tests/FlattenDrawableTest.c... tests/FlattenDrawableTest.cpp:257: DEF_TEST(FlattenCustomDrawable, r) { On 2016/04/26 15:17:24, mtklein wrote: > Does this make this test moot? Yes... I'll delete this.
Message was sent while issue was closed.
Description was changed from ========== Do not globally register drawables in test code TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Do not globally register drawables in test code TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/002c92bcbf3baf6689b0c1ece11eb01c32ac770a ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/002c92bcbf3baf6689b0c1ece11eb01c32ac770a |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
