Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1922843002: Add XML header to test SVG file (Closed)

Created:
4 years, 8 months ago by Jinsuk Kim
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add XML header to test SVG file WorldIso.svg is the only file in the SVG performance test suite that's missing the xml header. This triggered auto-encoding detector or UTF-8 encoding detector and caused extra amount of time in the result, which is not the purpose of the test suite. Added a header used in other svg (Worldcup.svg). This fixes the regression reported in blink_perf.svg. BUG=606267 Committed: https://crrev.com/472f4e7c9b1ce63e453be41e938520dec30af46b Cr-Commit-Position: refs/heads/master@{#389923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/PerformanceTests/SVG/resources/WorldIso.svg View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jinsuk Kim
4 years, 8 months ago (2016-04-26 07:17:49 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-26 18:49:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922843002/1
4 years, 8 months ago (2016-04-26 21:24:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 22:37:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 22:39:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/472f4e7c9b1ce63e453be41e938520dec30af46b
Cr-Commit-Position: refs/heads/master@{#389923}

Powered by Google App Engine
This is Rietveld 408576698