Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1922833003: Use webView instance variable instead of getter. (Closed)

Created:
4 years, 8 months ago by michaeldo
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use webView instance variable instead of getter. BUG=579697 Committed: https://crrev.com/9f0095b49465f4520ac346534b4e50cc9c755698 Cr-Commit-Position: refs/heads/master@{#389827}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -75 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 56 chunks +72 lines, -75 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
michaeldo
I was unfortunately unable to remove the webView property and getter as it is needed ...
4 years, 8 months ago (2016-04-26 17:53:13 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/1922833003/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/1922833003/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode4812 ios/web/web_state/ui/crw_web_controller.mm:4812: return child.webView; child->_webView could work, but I would ...
4 years, 8 months ago (2016-04-26 18:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922833003/1
4 years, 8 months ago (2016-04-26 18:02:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 18:55:34 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 18:57:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f0095b49465f4520ac346534b4e50cc9c755698
Cr-Commit-Position: refs/heads/master@{#389827}

Powered by Google App Engine
This is Rietveld 408576698