Add frame ID to LayoutAnalyzer trace event

third_party/WebKit/Source/core/frame/FrameView.cpp

Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 98694595bae6d8467bfcecff372341f523cf8255..5f9706686698da776d329ccce873444ba477844e 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -839,6 +839,7 @@ PassOwnPtr<TracedValue> FrameView::analyzerCounters()
         return TracedValue::create();
     OwnPtr<TracedValue> value = m_analyzer->toTracedValue();
     value->setString("host", layoutView()->document().location()->host());
+    value->setString("frame", String::format("0x%" PRIx64, static_cast<uint64_t>(reinterpret_cast<intptr_t>(m_frame.get()))));

[benjhayden, 2016/04/27 16:36:06]

Yeah, sorry this is super non-obvious, but I'm told that the correct way to
stringify pointers is like this:
value->setString("frame", String::format("%" PRIxPTR,
reinterpret_cast<uintptr_t>(m_frame.get())));

[Kunihiko Sakamoto, 2016/04/28 02:56:06]

Thanks for the tip, done.
Let me keep the "0x" prefix for consistency with other trace events.

[benjhayden, 2016/04/28 04:22:10]

Doesn't the PRIxPTR already generate the 0x prefix?

[Kunihiko Sakamoto, 2016/04/28 04:47:23]

No, on my Linux box, PRIxPTR is expanded to "lx" so 0x is not prepended.

     return value.release();
 }