Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: build/android/gyp/lint.py

Issue 1922823002: [Android] Add documentation for lint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/docs/lint.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/lint.py
diff --git a/build/android/gyp/lint.py b/build/android/gyp/lint.py
index cc44a43716f968e479c5a9f69ca723cc9d60182b..2efe9f856fb9611d3124912055940128df2687a9 100755
--- a/build/android/gyp/lint.py
+++ b/build/android/gyp/lint.py
@@ -16,7 +16,7 @@ from xml.dom import minidom
from util import build_utils
-
+_LINT_MD_URL = 'https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md' # pylint: disable=line-too-long
_SRC_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__),
'..', '..', '..'))
@@ -196,17 +196,12 @@ def _OnStaleMd5(lint_path, config_path, processed_config_path,
_ProcessResultFile()
msg = ('\nLint found %d new issues.\n'
- ' - For full explanation refer to %s\n' %
+ ' - For full explanation, please refer to %s\n'
+ ' - For more information about lint and how to fix lint issues,'
+ ' please refer to %s\n' %
(num_issues,
- _RelativizePath(result_path)))
- if config_path:
- msg += (' - Wanna suppress these issues?\n'
- ' 1. Read comment in %s\n'
- ' 2. Run "python %s %s"\n' %
- (_RelativizePath(config_path),
- _RelativizePath(os.path.join(_SRC_ROOT, 'build', 'android',
- 'lint', 'suppress.py')),
- _RelativizePath(result_path)))
+ _RelativizePath(result_path),
+ _LINT_MD_URL))
if not silent:
print >> sys.stderr, msg
if can_fail_build:
« no previous file with comments | « build/android/docs/lint.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698