Move deferred commit logic from WebViewImpl to Document.

third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 162 matching lines @@
     // FIXME: when extensions go out of process, this whole concept stops working.
     WebDevToolsFrontendImpl* devToolsFrontend = m_webFrame->top()->isWebLocalFrame() ? toWebLocalFrameImpl(m_webFrame->top())->devToolsFrontend() : nullptr;
     if (devToolsFrontend)
         devToolsFrontend->didClearWindowObject(m_webFrame);
 }
 
 void FrameLoaderClientImpl::documentElementAvailable()
 {
     if (m_webFrame->client())
         m_webFrame->client()->didCreateDocumentElement(m_webFrame);
-
-    if (m_webFrame->parent())
-        return;
-
-    if (m_webFrame->viewImpl())
-        m_webFrame->viewImpl()->mainFrameDocumentElementAvailable();
 }
 
 void FrameLoaderClientImpl::runScriptsAtDocumentElementAvailable()
 {
     if (m_webFrame->client())
         m_webFrame->client()->runScriptsAtDocumentElementAvailable(m_webFrame);
     // The callback might have deleted the frame, do not use |this|!
 }
 
 void FrameLoaderClientImpl::runScriptsAtDocumentReady(bool documentIsEmpty)
@@ skipping 30 matching lines @@
     if (m_webFrame->client())
         m_webFrame->client()->didChangeScrollOffset(m_webFrame);
 }
 
 void FrameLoaderClientImpl::didUpdateCurrentHistoryItem()
 {
     if (m_webFrame->client())
         m_webFrame->client()->didUpdateCurrentHistoryItem();
 }
 
-// TODO(dglazkov): Can this be plumbing be streamlined out?
-void FrameLoaderClientImpl::didRemoveAllPendingStylesheet()
-{
-    if (m_webFrame->parent())
-        return;
-
-    if (WebViewImpl* webview = m_webFrame->viewImpl())
-        webview->didRemoveAllPendingStylesheetsInMainFrameDocument();
-}
-
 bool FrameLoaderClientImpl::allowScript(bool enabledPerSettings)
 {
     if (m_webFrame->contentSettingsClient())
         return m_webFrame->contentSettingsClient()->allowScript(enabledPerSettings);
 
     return enabledPerSettings;
 }
 
 bool FrameLoaderClientImpl::allowScriptFromSource(bool enabledPerSettings, const KURL& scriptURL)
 {
@@ skipping 172 matching lines @@
 // Called when a particular resource load completes
 void FrameLoaderClientImpl::dispatchDidFinishLoading(DocumentLoader* loader,
                                                     unsigned long identifier)
 {
     if (m_webFrame->client())
         m_webFrame->client()->didFinishResourceLoad(m_webFrame, identifier);
 }
 
 void FrameLoaderClientImpl::dispatchDidFinishDocumentLoad()
 {
-    if (!m_webFrame->parent()) {
-        if (WebViewImpl* webview = m_webFrame->viewImpl())
-            webview->didFinishMainFrameDocumentLoad();
-    }
-
     // TODO(dglazkov): Sadly, workers are WebFrameClients, and they can totally
     // destroy themselves when didFinishDocumentLoad is invoked, and in turn destroy
     // the fake WebLocalFrame that they create, which means that you should not
     // put any code touching `this` after the two lines below.
     if (m_webFrame->client())
         m_webFrame->client()->didFinishDocumentLoad(m_webFrame);
 }
 
 void FrameLoaderClientImpl::dispatchDidLoadResourceFromMemoryCache(const ResourceRequest& request, const ResourceResponse& response)
 {
@@ skipping 521 matching lines @@
 {
     if (m_webFrame->client())
         return m_webFrame->client()->allowWebGL(enabledPerSettings);
 
     return enabledPerSettings;
 }
 
 void FrameLoaderClientImpl::dispatchWillInsertBody()
 {
     if (m_webFrame->client())
         m_webFrame->client()->willInsertBody(m_webFrame);

[Bryan McQuade, 2016/04/26 14:28:34]

it's great that we're reducing the callbacks from blink to the outside that have
to know about inserting the body of the document. seems like clients should not
have to know about an implementation detail like body being inserted, especially
given that not all types of documents have a body.

it looks like the only code at this point that cares about the body being
inserted is in ResourceScheduler::OnWillInsertBody. rdsmith is working on
removing ResourceScheduler, so when that goes, it seems like we should be able
to remove this method, as well as willInsertBody and the downstream plumbing.

will add rdsmith to this review as FYI so he can remove this as part of his
ResourceScheduler work.

-
-    if (m_webFrame->parent())
-        return;
-
-    if (m_webFrame->viewImpl())
-        m_webFrame->viewImpl()->willInsertMainFrameDocumentBody();
 }
 
 PassOwnPtr<WebServiceWorkerProvider> FrameLoaderClientImpl::createServiceWorkerProvider()
 {
     if (!m_webFrame->client())
         return nullptr;
     return adoptPtr(m_webFrame->client()->createServiceWorkerProvider());
 }
 
 bool FrameLoaderClientImpl::isControlledByServiceWorker(DocumentLoader& loader)
@@ skipping 48 matching lines @@
         return nullptr;
     return m_webFrame->client()->frameBlameContext();
 }
 
 LinkResource* FrameLoaderClientImpl::createServiceWorkerLinkResource(HTMLLinkElement* owner)
 {
     return ServiceWorkerLinkResource::create(owner);
 }
 
 } // namespace blink