Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceObserver.h

Issue 1922763003: Remove unnecessary uses of GarbageCollectedFinalized<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceObserver.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceObserver.h b/third_party/WebKit/Source/core/timing/PerformanceObserver.h
index 7104487ccd6c8a7a5a63068159188c566900b5a2..fd13c40da2e1f492434e907f4d5e2e2f7661da92 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceObserver.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceObserver.h
@@ -8,6 +8,11 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/timing/PerformanceEntry.h"
#include "platform/heap/Handle.h"
+#include "wtf/HashSet.h"
sof 2016/04/26 11:07:39 oops, these unused ones were mistakenly re-added h
+#include "wtf/PassOwnPtr.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefCounted.h"
+#include "wtf/RefPtr.h"
#include "wtf/Vector.h"
namespace blink {
@@ -20,22 +25,18 @@ class PerformanceObserverInit;
using PerformanceEntryVector = HeapVector<Member<PerformanceEntry>>;
-class PerformanceObserver final : public GarbageCollectedFinalized<PerformanceObserver>, public ScriptWrappable {
+class PerformanceObserver final : public GarbageCollected<PerformanceObserver>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
friend class PerformanceBase;
public:
static PerformanceObserver* create(PerformanceBase*, PerformanceObserverCallback*);
static void resumeSuspendedObservers();
- ~PerformanceObserver();
-
void observe(const PerformanceObserverInit&, ExceptionState&);
void disconnect();
void enqueuePerformanceEntry(PerformanceEntry&);
PerformanceEntryTypeMask filterOptions() const { return m_filterOptions; }
- // Eagerly finalized as destructor accesses heap object members.
- EAGERLY_FINALIZE();
DECLARE_TRACE();
private:

Powered by Google App Engine
This is Rietveld 408576698