pkg/analysis_server/lib/src/single_context_manager.dart - Issue 1922743002: Add test for 'refresh()' and clean up other tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/single_context_manager.dart

Issue 1922743002: Add test for 'refresh()' and clean up other tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/single_context_manager.dart

diff --git a/pkg/analysis_server/lib/src/single_context_manager.dart b/pkg/analysis_server/lib/src/single_context_manager.dart

index 5a10513cf840fbaff71a2dc74ed38069ae5155ca..fc0704b90d0eb9ef4498fc5ad1a99c126dc59d2d 100644

--- a/pkg/analysis_server/lib/src/single_context_manager.dart

+++ b/pkg/analysis_server/lib/src/single_context_manager.dart

@@ -146,7 +146,6 @@ class SingleContextManager implements ContextManager {

@override

void refresh(List<Resource> roots) {

if (context != null) {

- // TODO(brianwilkerson) Not sure whether this is right.

callbacks.removeContext(contextFolder, null);

context.dispose();

context = null;

« no previous file with comments | « no previous file | pkg/analysis_server/test/single_context_manager_test.dart » ('j') | no next file with comments »