Add test for 'refresh()' and clean up other tests.

pkg/analysis_server/test/single_context_manager_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis_server.src.single_context_manager;
 
 import 'dart:core' hide Resource;
 
 import 'package:analysis_server/src/single_context_manager.dart';
-import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:analyzer/src/util/glob.dart';
 import 'package:linter/src/plugin/linter_plugin.dart';
 import 'package:path/path.dart';
 import 'package:plugin/manager.dart';
@@ skipping 12 matching lines @@
 }
 
 @reflectiveTest
 class SingleContextManagerTest {
   MemoryResourceProvider resourceProvider = new MemoryResourceProvider();
 
   TestUriResolver packageResolver;
   TestContextManagerCallbacks callbacks;
   SingleContextManager manager;
 
-  /**
-   * TODO(scheglov) rename after copying tests!
-   */
-  String projPath = '/my/project';
-  Folder rootFolder;
-
   List<Glob> get analysisFilesGlobs {
     List<String> patterns = <String>[
       '**/*.${AnalysisEngine.SUFFIX_DART}',
       '**/*.${AnalysisEngine.SUFFIX_HTML}',
     ];
     return patterns
         .map((pattern) => new Glob(JavaFile.pathContext.separator, pattern))
         .toList();
   }
 
   String newFile(List<String> pathComponents, [String content = '']) {
     String filePath = posix.joinAll(pathComponents);
     resourceProvider.newFile(filePath, content);
     return filePath;
   }
 
   String newFolder(List<String> pathComponents) {
     String folderPath = posix.joinAll(pathComponents);
     resourceProvider.newFolder(folderPath);
     return folderPath;
   }
 
   void setUp() {
-    rootFolder = resourceProvider.newFolder(projPath);
-    packageResolver = new TestUriResolver(resourceProvider, rootFolder);
+    packageResolver = new TestUriResolver();
 
     _processRequiredPlugins();
     DartSdkManager sdkManager = new DartSdkManager((_) {
       return new MockSdk();
     });
     manager = new SingleContextManager(resourceProvider, sdkManager,
         () => packageResolver, analysisFilesGlobs);
     callbacks = new TestContextManagerCallbacks(resourceProvider);
     manager.callbacks = callbacks;
-    resourceProvider.newFolder(projPath);
   }
 
   void test_isIgnored_false() {
     String project = '/project';
     manager.setRoots(<String>[project], <String>[], <String, String>{});
     expect(manager.isIgnored('$project/file.dart'), isFalse);
   }
 
   void test_isIgnored_true_inDotFolder() {
     String project = '/project';
@@ skipping 30 matching lines @@
     manager.setRoots(<String>[root1, root2], <String>[], <String, String>{});
     expect(manager.isInAnalysisRoot('$context/root3/file.dart'), isFalse);
   }
 
   void test_isInAnalysisRoot_true() {
     String project = '/project';
     manager.setRoots(<String>[project], <String>[], <String, String>{});
     expect(manager.isInAnalysisRoot('$project/file.dart'), isTrue);
   }
 
+  void test_refresh() {
+    String project = '/project';
+    String file1 = '$project/file1.dart';
+    String file2 = '$project/file2.dart';
+    // create files
+    resourceProvider.newFile(file1, '');
+    resourceProvider.newFile(file2, '');
+    // set roots
+    manager.setRoots(<String>[project], <String>[file2], <String, String>{});
+    callbacks.assertContextPaths([project]);
+    callbacks.assertContextFiles(project, [file1]);
+    // refresh
+    manager.refresh([]);
+    callbacks.assertContextPaths([project]);
+    callbacks.assertContextFiles(project, [file1]);
+  }
+
   void test_setRoots_addFolderWithDartFile() {
-    String filePath = posix.join(projPath, 'lib', 'foo.dart');
-    resourceProvider.newFile(filePath, 'contents');
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    String project = '/project';
+    String file = '$project/lib/foo.dart';
+    resourceProvider.newFile(file, '');
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // verify
-    callbacks.assertContextFiles(projPath, [filePath]);
-    // There is an analysis context.
-    List<AnalysisContext> contextsInAnalysisRoot =
-        manager.contextsInAnalysisRoot(rootFolder);
-    expect(contextsInAnalysisRoot, hasLength(1));
-    AnalysisContext context = contextsInAnalysisRoot[0];
-    expect(context, isNotNull);
-    // Files in lib/ have package: URIs.
-    Source result = context.sourceFactory.forUri('package:foo/foo.dart');
-    expect(result, isNotNull);
-    expect(result.exists(), isTrue);
+    callbacks.assertContextPaths([project]);
+    callbacks.assertContextFiles(project, [file]);
   }
 
   void test_setRoots_addFolderWithDartFileInSubfolder() {
-    String filePath = posix.join(projPath, 'foo', 'bar.dart');
-    resourceProvider.newFile(filePath, 'contents');
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    String project = '/project';
+    String file = '$project/foo/bar.dart';
+    resourceProvider.newFile(file, '');
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // verify
-    callbacks.assertContextFiles(projPath, [filePath]);
+    callbacks.assertContextFiles(project, [file]);
   }
 
   void test_setRoots_addFolderWithDummyLink() {
-    String filePath = posix.join(projPath, 'foo.dart');
-    resourceProvider.newDummyLink(filePath);
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    String project = '/project';
+    String file = '$project/foo.dart';
+    resourceProvider.newDummyLink(file);
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // verify
-    callbacks.assertContextFiles(projPath, []);
+    callbacks.assertContextFiles(project, []);
   }
 
   void test_setRoots_exclude_newRoot_withExcludedFile() {
     String project = '/project';
     String file1 = '$project/file1.dart';
     String file2 = '$project/file2.dart';
     // create files
-    resourceProvider.newFile(file1, '// 1');
-    resourceProvider.newFile(file2, '// 2');
+    resourceProvider.newFile(file1, '');
+    resourceProvider.newFile(file2, '');
     // set roots
     manager.setRoots(<String>[project], <String>[file1], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [file2]);
   }
 
   void test_setRoots_exclude_newRoot_withExcludedFolder() {
     String project = '/project';
     String folderA = '$project/aaa';
     String folderB = '$project/bbb';
     String fileA = '$folderA/a.dart';
     String fileB = '$folderB/b.dart';
     // create files
-    resourceProvider.newFile(fileA, 'library a;');
-    resourceProvider.newFile(fileB, 'library b;');
+    resourceProvider.newFile(fileA, '');
+    resourceProvider.newFile(fileB, '');
     // set roots
     manager.setRoots(<String>[project], <String>[folderB], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [fileA]);
   }
 
   void test_setRoots_exclude_sameRoot_addExcludedFile() {
     String project = '/project';
     String file1 = '$project/file1.dart';
     String file2 = '$project/file2.dart';
     // create files
-    resourceProvider.newFile(file1, '// 1');
-    resourceProvider.newFile(file2, '// 2');
+    resourceProvider.newFile(file1, '');
+    resourceProvider.newFile(file2, '');
     // set roots
     manager.setRoots(<String>[project], <String>[], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [file1, file2]);
     // exclude "2"
     manager.setRoots(<String>[project], <String>[file2], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [file1]);
   }
 
@@ skipping 63 matching lines @@
     manager.setRoots(<String>[project], <String>[folderB], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [fileA]);
     // stop excluding "bbb/"
     manager.setRoots(<String>[project], <String>[], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [fileA, fileB]);
   }
 
   void test_setRoots_ignoreGlobs() {
-    String file1 = '$projPath/file.dart';
-    String file2 = '$projPath/file.foo';
+    String project = '/project';
+    String file1 = '$project/file.dart';
+    String file2 = '$project/file.foo';
     // create files
     resourceProvider.newFile(file1, '');
     resourceProvider.newFile(file2, '');
     // set roots
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
-    callbacks.assertContextPaths([projPath]);
-    callbacks.assertContextFiles(projPath, [file1]);
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
+    callbacks.assertContextPaths([project]);
+    callbacks.assertContextFiles(project, [file1]);
   }
 
   void test_setRoots_newContextFolder_coverNewRoot() {
     String contextPath = '/context';
     String root1 = '$contextPath/root1';
     String file1 = '$root1/file1.dart';
     String root2 = '$contextPath/root2';
     String file2 = '$root2/file1.dart';
     // create files
     resourceProvider.newFile(file1, '');
@@ skipping 57 matching lines @@
     // context to be ignored.
     String project = '/.pub/project';
     String fileA = '$project/foo.dart';
     resourceProvider.newFile(fileA, '');
     manager.setRoots(<String>[project], <String>[], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [fileA]);
   }
 
   test_watch_addFile() async {
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    String project = '/project';
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // empty folder initially
-    callbacks.assertContextFiles(projPath, []);
+    callbacks.assertContextFiles(project, []);
     // add file
-    String filePath = posix.join(projPath, 'foo.dart');
-    resourceProvider.newFile(filePath, 'contents');
+    String file = '$project/foo.dart';
+    resourceProvider.newFile(file, 'contents');
     // the file was added
     await pumpEventQueue();
-    callbacks.assertContextFiles(projPath, [filePath]);
+    callbacks.assertContextFiles(project, [file]);
   }
 
   test_watch_addFile_excluded() async {
-    String folderA = '$projPath/aaa';
-    String folderB = '$projPath/bbb';
+    String project = '/project';
+    String folderA = '$project/aaa';
+    String folderB = '$project/bbb';
     String fileA = '$folderA/a.dart';
     String fileB = '$folderB/b.dart';
     // create files
     resourceProvider.newFile(fileA, 'library a;');
     // set roots
-    manager.setRoots(<String>[projPath], <String>[folderB], <String, String>{});
-    callbacks.assertContextPaths([projPath]);
-    callbacks.assertContextFiles(projPath, [fileA]);
+    manager.setRoots(<String>[project], <String>[folderB], <String, String>{});
+    callbacks.assertContextPaths([project]);
+    callbacks.assertContextFiles(project, [fileA]);
     // add a file, ignored as excluded
     resourceProvider.newFile(fileB, 'library b;');
     await pumpEventQueue();
-    callbacks.assertContextPaths([projPath]);
-    callbacks.assertContextFiles(projPath, [fileA]);
+    callbacks.assertContextPaths([project]);
+    callbacks.assertContextFiles(project, [fileA]);
   }
 
   test_watch_addFile_notInRoot() async {
     String contextPath = '/roots';
     String root1 = '$contextPath/root1';
     String root2 = '$contextPath/root2';
     String root3 = '$contextPath/root3';
     String file1 = '$root1/file1.dart';
     String file2 = '$root2/file2.dart';
     String file3 = '$root3/file3.dart';
@@ skipping 21 matching lines @@
     manager.setRoots(<String>[project], <String>[], <String, String>{});
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [fileA]);
     resourceProvider.newFile(fileB, '');
     await pumpEventQueue();
     callbacks.assertContextPaths([project]);
     callbacks.assertContextFiles(project, [fileA]);
   }
 
   test_watch_addFileInSubfolder() async {
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    String project = '/project';
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // empty folder initially
-    callbacks.assertContextFiles(projPath, []);
+    callbacks.assertContextFiles(project, []);
     // add file in subfolder
-    String filePath = posix.join(projPath, 'foo', 'bar.dart');
-    resourceProvider.newFile(filePath, 'contents');
+    String file = '$project/foo/bar.dart';
+    resourceProvider.newFile(file, 'contents');
     // the file was added
     await pumpEventQueue();
-    callbacks.assertContextFiles(projPath, [filePath]);
+    callbacks.assertContextFiles(project, [file]);
   }
 
   test_watch_deleteFile() async {
-    String filePath = posix.join(projPath, 'foo.dart');
+    String project = '/project';
+    String file = '$project/foo.dart';
     // add root with a file
-    resourceProvider.newFile(filePath, 'contents');
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    resourceProvider.newFile(file, 'contents');
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // the file was added
-    callbacks.assertContextFiles(projPath, [filePath]);
+    callbacks.assertContextFiles(project, [file]);
     // delete the file
-    resourceProvider.deleteFile(filePath);
+    resourceProvider.deleteFile(file);
     await pumpEventQueue();
-    callbacks.assertContextFiles(projPath, []);
+    callbacks.assertContextFiles(project, []);
   }
 
   test_watch_deleteFolder() async {
-    String filePath = posix.join(projPath, 'foo.dart');
+    String project = '/project';
+    String file = '$project/foo.dart';
     // add root with a file
-    resourceProvider.newFile(filePath, 'contents');
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    resourceProvider.newFile(file, 'contents');
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // the file was added
-    callbacks.assertContextFiles(projPath, [filePath]);
+    callbacks.assertContextFiles(project, [file]);
     // delete the folder
-    resourceProvider.deleteFolder(projPath);
+    resourceProvider.deleteFolder(project);
     await pumpEventQueue();
-    callbacks.assertContextFiles(projPath, []);
+    callbacks.assertContextFiles(project, []);
   }
 
   test_watch_modifyFile() async {
-    String filePath = posix.join(projPath, 'foo.dart');
+    String project = '/project';
+    String file = '$project/foo.dart';
     // add root with a file
-    resourceProvider.newFile(filePath, 'contents');
-    manager.setRoots(<String>[projPath], <String>[], <String, String>{});
+    resourceProvider.newFile(file, 'contents');
+    manager.setRoots(<String>[project], <String>[], <String, String>{});
     // the file was added
-    Map<String, int> filePaths = callbacks.currentContextFilePaths[projPath];
+    Map<String, int> filePaths = callbacks.currentContextFilePaths[project];
     expect(filePaths, hasLength(1));
-    expect(filePaths, contains(filePath));
-    expect(filePaths[filePath], equals(callbacks.now));
+    expect(filePaths, contains(file));
+    expect(filePaths[file], equals(callbacks.now));
     // update the file
     callbacks.now++;
-    resourceProvider.modifyFile(filePath, 'new contents');
+    resourceProvider.modifyFile(file, 'new contents');
     await pumpEventQueue();
-    return expect(filePaths[filePath], equals(callbacks.now));
+    return expect(filePaths[file], equals(callbacks.now));
   }
 
   void _processRequiredPlugins() {
     List<Plugin> plugins = <Plugin>[];
     plugins.addAll(AnalysisEngine.instance.requiredPlugins);
     plugins.add(AnalysisEngine.instance.commandLinePlugin);
     plugins.add(AnalysisEngine.instance.optionsPlugin);
     plugins.add(linterPlugin);
     ExtensionManager manager = new ExtensionManager();
     manager.processPlugins(plugins);
   }
 }
 
 class TestUriResolver extends UriResolver {
-  final ResourceProvider resourceProvider;
-  final Folder rootFolder;
-
-  TestUriResolver(this.resourceProvider, this.rootFolder);
-
   @override
   Source resolveAbsolute(Uri uri, [Uri actualUri]) {
-    if (uri.scheme == 'package') {
-      List<String> segments = uri.pathSegments;
-      if (segments.length >= 2) {
-        List<String> relSegments = <String>['lib']..addAll(segments.skip(1));
-        String relPath = resourceProvider.pathContext.joinAll(relSegments);
-        Resource file = rootFolder.getChild(relPath);
-        if (file is File && file.exists) {
-          return file.createSource(uri);
-        }
-      }
-    }
     return null;
   }
 }