Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1922733002: Revert of Make `git cl description` work for Gerrit (Closed)

Created:
4 years, 7 months ago by hinoka
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ ) Reason for revert: Broke presubmit Original issue's description: > Make `git cl description` work for Gerrit > > This works in that it actually changes the description, but after > multiple changes, there's multiple footers added. I'm not sure if they > should be stripped in setting the description? Or is the problem in > FetchDescription() where it shouldn't be returning > 'commit_with_footers', but rather something else? > > Example change at https://chromium-review.googlesource.com/c/340430/. > > R=tandrii@chromium.org > BUG=603207 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169 TBR=tandrii@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603207 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M gerrit_util.py View 1 chunk +0 lines, -32 lines 0 comments Download
M git_cl.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hinoka
Created Revert of Make `git cl description` work for Gerrit
4 years, 7 months ago (2016-04-25 22:02:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922733002/1
4 years, 7 months ago (2016-04-25 22:03:01 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 22:03:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300175

Powered by Google App Engine
This is Rietveld 408576698