Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1922723002:
Revert of Make `git cl description` work for Gerrit (Closed)
|
Created:
4 years, 7 months ago by Ryan Tseng Modified:
4 years, 7 months ago CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionRevert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ )
Reason for revert:
Broke presubmit?
Original issue's description:
> Make `git cl description` work for Gerrit
>
> This works in that it actually changes the description, but after
> multiple changes, there's multiple footers added. I'm not sure if they
> should be stripped in setting the description? Or is the problem in
> FetchDescription() where it shouldn't be returning
> 'commit_with_footers', but rather something else?
>
> Example change at https://chromium-review.googlesource.com/c/340430/.
>
> R=tandrii@chromium.org
> BUG=603207
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169
TBR=tandrii@chromium.org,scottmg@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603207
Patch Set 1 #Messages
Total messages: 23 (11 generated)
Created Revert of Make `git cl description` work for Gerrit
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922723002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ ) Reason for revert: Broke presubmit Original issue's description: > Make `git cl description` work for Gerrit > > This works in that it actually changes the description, but after > multiple changes, there's multiple footers added. I'm not sure if they > should be stripped in setting the description? Or is the problem in > FetchDescription() where it shouldn't be returning > 'commit_with_footers', but rather something else? > > Example change at https://chromium-review.googlesource.com/c/340430/. > > R=tandrii@chromium.org > BUG=603207 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169 TBR=tandrii@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603207 ========== to ========== Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ ) Reason for revert: Broke presubmit? Original issue's description: > Make `git cl description` work for Gerrit > > This works in that it actually changes the description, but after > multiple changes, there's multiple footers added. I'm not sure if they > should be stripped in setting the description? Or is the problem in > FetchDescription() where it shouldn't be returning > 'commit_with_footers', but rather something else? > > Example change at https://chromium-review.googlesource.com/c/340430/. > > R=tandrii@chromium.org > BUG=603207 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169 TBR=tandrii@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603207 ==========
Description was changed from ========== Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ ) Reason for revert: Broke presubmit? Original issue's description: > Make `git cl description` work for Gerrit > > This works in that it actually changes the description, but after > multiple changes, there's multiple footers added. I'm not sure if they > should be stripped in setting the description? Or is the problem in > FetchDescription() where it shouldn't be returning > 'commit_with_footers', but rather something else? > > Example change at https://chromium-review.googlesource.com/c/340430/. > > R=tandrii@chromium.org > BUG=603207 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169 TBR=tandrii@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603207 ========== to ========== Revert of Make `git cl description` work for Gerrit (patchset #2 id:20001 of https://codereview.chromium.org/1917473002/ ) Reason for revert: Broke presubmit? Original issue's description: > Make `git cl description` work for Gerrit > > This works in that it actually changes the description, but after > multiple changes, there's multiple footers added. I'm not sure if they > should be stripped in setting the description? Or is the problem in > FetchDescription() where it shouldn't be returning > 'commit_with_footers', but rather something else? > > Example change at https://chromium-review.googlesource.com/c/340430/. > > R=tandrii@chromium.org > BUG=603207 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=300169 TBR=tandrii@chromium.org,scottmg@chromium.org,iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603207 ==========
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922723002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by hinoka@chromium.org
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922723002/1
The CQ bit was checked by hinoka@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922723002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Sorry, thanks. I have no idea how that broke things.
I'm not sure either, pylint is strange. On Mon, Apr 25, 2016 at 3:02 PM, <scottmg@chromium.org> wrote: > Sorry, thanks. I have no idea how that broke things. > > https://codereview.chromium.org/1922723002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Actually, no, pyling isn't strange :) This was the last NotImplementedError, making the class no-longer abstract, hence a new check by pylint :) So, solution is simple, we just have to create a new TODO method :) On 2016/04/25 22:03:38, chromium-reviews wrote: > I'm not sure either, pylint is strange. > > On Mon, Apr 25, 2016 at 3:02 PM, <mailto:scottmg@chromium.org> wrote: > > > Sorry, thanks. I have no idea how that broke things. > > > > https://codereview.chromium.org/1922723002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. |
