Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1922703005: Allow CpuProfiler::SetIdle to be called while executing JS. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
alph, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow CpuProfiler::SetIdle to be called while executing JS. This could be the case when running nested message loop while paused in debugger. BUG=none LOG=N Committed: https://crrev.com/9cf856a8cec94dab9a366afa9f2edafd512cd71e Cr-Commit-Position: refs/heads/master@{#35880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Could you please take a look? alph@ for profiler; adamk@ for owners. This is a ...
4 years, 8 months ago (2016-04-27 00:49:35 UTC) #2
alph
lgtm
4 years, 7 months ago (2016-04-28 07:35:15 UTC) #3
adamk
Seems reasonable to me, lgtm deferring to alph's knowledge of the profiler here.
4 years, 7 months ago (2016-04-28 19:29:09 UTC) #4
dgozman
Thanks for review!
4 years, 7 months ago (2016-04-28 19:33:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922703005/1
4 years, 7 months ago (2016-04-28 19:34:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 19:57:36 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cf856a8cec94dab9a366afa9f2edafd512cd71e
Cr-Commit-Position: refs/heads/master@{#35880}

Powered by Google App Engine
This is Rietveld 408576698